From 4ebee933c422b77647afaadb56179d04e8de85f4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zdene=CC=8Ck=20Drahos=CC=8C?= <drahoszdenek@gmail.com>
Date: Sun, 27 Jun 2021 08:41:33 +0200
Subject: [PATCH] Extract rendering docs from command and controller

---
 Command/DumpCommand.php             | 32 ++++--------
 Controller/SwaggerUiController.php  | 52 ++++++++------------
 Render/Html/HtmlOpenApiRenderer.php | 56 +++++++++++++++++++++
 Render/Json/JsonOpenApiRenderer.php | 34 +++++++++++++
 Render/OpenApiRenderer.php          | 21 ++++++++
 Render/RenderOpenApi.php            | 53 ++++++++++++++++++++
 Resources/config/services.xml       | 17 +++++--
 Tests/Command/DumpCommandTest.php   | 31 +++++++++---
 Tests/Render/RenderOpenApiTest.php  | 75 +++++++++++++++++++++++++++++
 9 files changed, 305 insertions(+), 66 deletions(-)
 create mode 100644 Render/Html/HtmlOpenApiRenderer.php
 create mode 100644 Render/Json/JsonOpenApiRenderer.php
 create mode 100644 Render/OpenApiRenderer.php
 create mode 100644 Render/RenderOpenApi.php
 create mode 100644 Tests/Render/RenderOpenApiTest.php

diff --git a/Command/DumpCommand.php b/Command/DumpCommand.php
index f1b6271..b2438da 100644
--- a/Command/DumpCommand.php
+++ b/Command/DumpCommand.php
@@ -11,9 +11,8 @@
 
 namespace Nelmio\ApiDocBundle\Command;
 
-use Psr\Container\ContainerInterface;
+use Nelmio\ApiDocBundle\Render\RenderOpenApi;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Exception\InvalidArgumentException;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -21,16 +20,13 @@ use Symfony\Component\Console\Output\OutputInterface;
 class DumpCommand extends Command
 {
     /**
-     * @var ContainerInterface
+     * @var RenderOpenApi
      */
-    private $generatorLocator;
+    private $renderOpenApi;
 
-    /**
-     * DumpCommand constructor.
-     */
-    public function __construct(ContainerInterface $generatorLocator)
+    public function __construct(RenderOpenApi $renderOpenApi)
     {
-        $this->generatorLocator = $generatorLocator;
+        $this->renderOpenApi = $renderOpenApi;
 
         parent::__construct();
     }
@@ -48,25 +44,17 @@ class DumpCommand extends Command
     }
 
     /**
-     * @throws InvalidArgumentException If the area to dump is not valid
-     *
      * @return int|void
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
         $area = $input->getOption('area');
 
-        if (!$this->generatorLocator->has($area)) {
-            throw new InvalidArgumentException(sprintf('Area "%s" is not supported.', $area));
-        }
-
-        $spec = $this->generatorLocator->get($area)->generate();
-
-        if ($input->hasParameterOption(['--no-pretty'])) {
-            $output->writeln(json_encode($spec));
-        } else {
-            $output->writeln(json_encode($spec, JSON_PRETTY_PRINT));
-        }
+        $options = [
+            'no-pretty' => $input->hasParameterOption(['--no-pretty']),
+        ];
+        $docs = $this->renderOpenApi->render(RenderOpenApi::JSON, $area, $options);
+        $output->writeln($docs, OutputInterface::OUTPUT_RAW);
 
         return 0;
     }
diff --git a/Controller/SwaggerUiController.php b/Controller/SwaggerUiController.php
index 2b3d962..4edad7f 100644
--- a/Controller/SwaggerUiController.php
+++ b/Controller/SwaggerUiController.php
@@ -11,33 +11,37 @@
 
 namespace Nelmio\ApiDocBundle\Controller;
 
-use OpenApi\Annotations\OpenApi;
-use OpenApi\Annotations\Server;
-use Psr\Container\ContainerInterface;
+use InvalidArgumentException;
+use Nelmio\ApiDocBundle\Render\RenderOpenApi;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
-use Twig\Environment;
 
 final class SwaggerUiController
 {
-    private $generatorLocator;
+    /**
+     * @var RenderOpenApi
+     */
+    private $renderOpenApi;
 
-    private $twig;
-
-    public function __construct(ContainerInterface $generatorLocator, $twig)
+    public function __construct(RenderOpenApi $renderOpenApi)
     {
-        if (!$twig instanceof \Twig_Environment && !$twig instanceof Environment) {
-            throw new \InvalidArgumentException(sprintf('Providing an instance of "%s" as twig is not supported.', get_class($twig)));
-        }
-
-        $this->generatorLocator = $generatorLocator;
-        $this->twig = $twig;
+        $this->renderOpenApi = $renderOpenApi;
     }
 
     public function __invoke(Request $request, $area = 'default')
     {
-        if (!$this->generatorLocator->has($area)) {
+        try {
+            $response = new Response(
+                $this->renderOpenApi->render(RenderOpenApi::HTML, $area, [
+                    'server_url' => '' !== $request->getBaseUrl() ? $request->getSchemeAndHttpHost().$request->getBaseUrl() : null,
+                ]),
+                Response::HTTP_OK,
+                ['Content-Type' => 'text/html']
+            );
+
+            return $response->setCharset('UTF-8');
+        } catch (InvalidArgumentException $e) {
             $advice = '';
             if (false !== strpos($area, '.json')) {
                 $advice = ' Since the area provided contains `.json`, the issue is likely caused by route priorities. Try switching the Swagger UI / the json documentation routes order.';
@@ -45,23 +49,5 @@ final class SwaggerUiController
 
             throw new BadRequestHttpException(sprintf('Area "%s" is not supported as it isn\'t defined in config.%s', $area, $advice));
         }
-
-        /** @var OpenApi $spec */
-        $spec = $this->generatorLocator->get($area)->generate();
-
-        if ('' !== $request->getBaseUrl()) {
-            $spec->servers = [new Server(['url' => $request->getSchemeAndHttpHost().$request->getBaseUrl()])];
-        }
-
-        return new Response(
-            $this->twig->render(
-                '@NelmioApiDoc/SwaggerUi/index.html.twig',
-                ['swagger_data' => ['spec' => json_decode($spec->toJson(), true)]]
-            ),
-            Response::HTTP_OK,
-            ['Content-Type' => 'text/html']
-        );
-
-        return $response->setCharset('UTF-8');
     }
 }
diff --git a/Render/Html/HtmlOpenApiRenderer.php b/Render/Html/HtmlOpenApiRenderer.php
new file mode 100644
index 0000000..32417be
--- /dev/null
+++ b/Render/Html/HtmlOpenApiRenderer.php
@@ -0,0 +1,56 @@
+<?php
+
+/*
+ * This file is part of the NelmioApiDocBundle package.
+ *
+ * (c) Nelmio
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Nelmio\ApiDocBundle\Render\Html;
+
+use InvalidArgumentException;
+use Nelmio\ApiDocBundle\Render\OpenApiRenderer;
+use Nelmio\ApiDocBundle\Render\RenderOpenApi;
+use OpenApi\Annotations\OpenApi;
+use OpenApi\Annotations\Server;
+use Twig\Environment;
+
+class HtmlOpenApiRenderer implements OpenApiRenderer
+{
+    /**
+     * @var Environment|\Twig_Environment
+     */
+    private $twig;
+
+    public function __construct($twig)
+    {
+        if (!$twig instanceof \Twig_Environment && !$twig instanceof Environment) {
+            throw new InvalidArgumentException(sprintf('Providing an instance of "%s" as twig is not supported.', get_class($twig)));
+        }
+        $this->twig = $twig;
+    }
+
+    public function getFormat(): string
+    {
+        return RenderOpenApi::HTML;
+    }
+
+    public function render(OpenApi $spec, array $options = []): string
+    {
+        $options += [
+            'server_url' => null,
+        ];
+
+        if ($options['server_url']) {
+            $spec->servers = [new Server(['url' => $options['server_url']])];
+        }
+
+        return $this->twig->render(
+            '@NelmioApiDoc/SwaggerUi/index.html.twig',
+            ['swagger_data' => ['spec' => json_decode($spec->toJson(), true)]]
+        );
+    }
+}
diff --git a/Render/Json/JsonOpenApiRenderer.php b/Render/Json/JsonOpenApiRenderer.php
new file mode 100644
index 0000000..09af9e1
--- /dev/null
+++ b/Render/Json/JsonOpenApiRenderer.php
@@ -0,0 +1,34 @@
+<?php
+
+/*
+ * This file is part of the NelmioApiDocBundle package.
+ *
+ * (c) Nelmio
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Nelmio\ApiDocBundle\Render\Json;
+
+use Nelmio\ApiDocBundle\Render\OpenApiRenderer;
+use Nelmio\ApiDocBundle\Render\RenderOpenApi;
+use OpenApi\Annotations\OpenApi;
+
+class JsonOpenApiRenderer implements OpenApiRenderer
+{
+    public function getFormat(): string
+    {
+        return RenderOpenApi::JSON;
+    }
+
+    public function render(OpenApi $spec, array $options = []): string
+    {
+        $options += [
+            'no-pretty' => false,
+        ];
+        $flags = $options['no-pretty'] ? 0 : JSON_PRETTY_PRINT;
+
+        return json_encode($spec, $flags);
+    }
+}
diff --git a/Render/OpenApiRenderer.php b/Render/OpenApiRenderer.php
new file mode 100644
index 0000000..5a672c4
--- /dev/null
+++ b/Render/OpenApiRenderer.php
@@ -0,0 +1,21 @@
+<?php
+
+/*
+ * This file is part of the NelmioApiDocBundle package.
+ *
+ * (c) Nelmio
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Nelmio\ApiDocBundle\Render;
+
+use OpenApi\Annotations\OpenApi;
+
+interface OpenApiRenderer
+{
+    public function getFormat(): string;
+
+    public function render(OpenApi $spec, array $options = []): string;
+}
diff --git a/Render/RenderOpenApi.php b/Render/RenderOpenApi.php
new file mode 100644
index 0000000..aace14f
--- /dev/null
+++ b/Render/RenderOpenApi.php
@@ -0,0 +1,53 @@
+<?php
+
+/*
+ * This file is part of the NelmioApiDocBundle package.
+ *
+ * (c) Nelmio
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Nelmio\ApiDocBundle\Render;
+
+use InvalidArgumentException;
+use OpenApi\Annotations\OpenApi;
+use Psr\Container\ContainerInterface;
+
+class RenderOpenApi
+{
+    public const HTML = 'html';
+    public const JSON = 'json';
+
+    /** @var ContainerInterface */
+    private $generatorLocator;
+
+    /** @var array<string, OpenApiRenderer> */
+    private $openApiRenderers = [];
+
+    public function __construct(ContainerInterface $generatorLocator, OpenApiRenderer ...$openApiRenderers)
+    {
+        $this->generatorLocator = $generatorLocator;
+        foreach ($openApiRenderers as $openApiRenderer) {
+            $this->openApiRenderers[$openApiRenderer->getFormat()] = $openApiRenderer;
+        }
+    }
+
+    /**
+     * @throws InvalidArgumentException If the area to dump is not valid
+     */
+    public function render(string $format, string $area, array $options = []): string
+    {
+        if (!$this->generatorLocator->has($area)) {
+            throw new InvalidArgumentException(sprintf('Area "%s" is not supported.', $area));
+        } elseif (!array_key_exists($format, $this->openApiRenderers)) {
+            throw new InvalidArgumentException(sprintf('Format "%s" is not supported.', $format));
+        }
+
+        /** @var OpenApi $spec */
+        $spec = $this->generatorLocator->get($area)->generate();
+
+        return $this->openApiRenderers[$format]->render($spec, $options);
+    }
+}
diff --git a/Resources/config/services.xml b/Resources/config/services.xml
index 8c888a6..47174fd 100644
--- a/Resources/config/services.xml
+++ b/Resources/config/services.xml
@@ -6,14 +6,13 @@
     <services>
         <!-- Commands -->
         <service id="nelmio_api_doc.command.dump" class="Nelmio\ApiDocBundle\Command\DumpCommand" public="true">
-            <argument type="service" id="nelmio_api_doc.generator_locator" />
+            <argument type="service" id="nelmio_api_doc.render_docs" />
             <tag name="console.command" command="nelmio:apidoc:dump" />
         </service>
 
         <!-- Controllers -->
         <service id="nelmio_api_doc.controller.swagger_ui" class="Nelmio\ApiDocBundle\Controller\SwaggerUiController" public="true">
-            <argument type="service" id="nelmio_api_doc.generator_locator" />
-            <argument type="service" id="twig" />
+            <argument type="service" id="nelmio_api_doc.render_docs" />
         </service>
 
         <service id="nelmio_api_doc.controller.swagger" alias="nelmio_api_doc.controller.swagger_json" public="true" />
@@ -26,6 +25,18 @@
             <argument type="service" id="nelmio_api_doc.generator_locator" />
         </service>
 
+        <!-- Render -->
+        <service id="nelmio_api_doc.render_docs" class="Nelmio\ApiDocBundle\Render\RenderOpenApi" public="true">
+            <argument type="service" id="nelmio_api_doc.generator_locator" />
+            <argument type="service" id="nelmio_api_doc.render_docs.html" />
+            <argument type="service" id="nelmio_api_doc.render_docs.json" />
+        </service>
+        <service id="nelmio_api_doc.render_docs.html" class="Nelmio\ApiDocBundle\Render\Html\HtmlOpenApiRenderer" public="false">
+            <argument type="service" id="twig" />
+        </service>
+        <service id="nelmio_api_doc.render_docs.json" class="Nelmio\ApiDocBundle\Render\Json\JsonOpenApiRenderer" public="false">
+        </service>
+
         <!-- Swagger Spec Generator -->
         <service id="nelmio_api_doc.generator" alias="nelmio_api_doc.generator.default" public="true" />
 
diff --git a/Tests/Command/DumpCommandTest.php b/Tests/Command/DumpCommandTest.php
index 2ccb15e..76902d2 100644
--- a/Tests/Command/DumpCommandTest.php
+++ b/Tests/Command/DumpCommandTest.php
@@ -17,20 +17,35 @@ use Symfony\Component\Console\Tester\CommandTester;
 
 class DumpCommandTest extends WebTestCase
 {
-    public function testExecute()
+    /** @dataProvider provideJsonMode */
+    public function testJson(array $jsonOptions, int $expectedJsonFlags)
+    {
+        $output = $this->executeDumpCommand($jsonOptions + [
+            '--area' => 'test',
+        ]);
+        $this->assertEquals(
+            json_encode($this->getOpenApiDefinition('test'), $expectedJsonFlags)."\n",
+            $output
+        );
+    }
+
+    public function provideJsonMode()
+    {
+        return [
+            'pretty print' => [[], JSON_PRETTY_PRINT],
+            'one line' => [['--no-pretty'], 0],
+        ];
+    }
+
+    private function executeDumpCommand(array $options)
     {
         $kernel = static::bootKernel();
         $application = new Application($kernel);
 
         $command = $application->find('nelmio:apidoc:dump');
         $commandTester = new CommandTester($command);
-        $commandTester->execute([
-            '--area' => 'test',
-            '--no-pretty' => '',
-        ]);
+        $commandTester->execute($options);
 
-        // the output of the command in the console
-        $output = $commandTester->getDisplay();
-        $this->assertEquals(json_encode($this->getOpenApiDefinition('test'))."\n", $output);
+        return $commandTester->getDisplay();
     }
 }
diff --git a/Tests/Render/RenderOpenApiTest.php b/Tests/Render/RenderOpenApiTest.php
new file mode 100644
index 0000000..d9b656b
--- /dev/null
+++ b/Tests/Render/RenderOpenApiTest.php
@@ -0,0 +1,75 @@
+<?php
+
+/*
+ * This file is part of the NelmioApiDocBundle package.
+ *
+ * (c) Nelmio
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Nelmio\ApiDocBundle\Tests\Render;
+
+use InvalidArgumentException;
+use Nelmio\ApiDocBundle\Render\OpenApiRenderer;
+use Nelmio\ApiDocBundle\Render\RenderOpenApi;
+use OpenApi\Annotations\OpenApi;
+use PHPUnit\Framework\TestCase;
+use Psr\Container\ContainerInterface;
+
+class RenderOpenApiTest extends TestCase
+{
+    private $area = 'irrelevant area';
+    private $format = 'irrelevant format';
+    private $hasArea = true;
+
+    public function testRender()
+    {
+        $openApiRenderer = $this->createMock(OpenApiRenderer::class);
+        $openApiRenderer->method('getFormat')->willReturn($this->format);
+        $openApiRenderer->expects($this->once())->method('render');
+        $this->renderOpenApi($openApiRenderer);
+    }
+
+    public function testUnknownFormat()
+    {
+        $availableOpenApiRenderers = [];
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectErrorMessage(sprintf('Format "%s" is not supported.', $this->format));
+        $this->renderOpenApi(...$availableOpenApiRenderers);
+    }
+
+    public function testUnknownArea()
+    {
+        $this->hasArea = false;
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectErrorMessage(sprintf('Area "%s" is not supported.', $this->area));
+        $this->renderOpenApi();
+    }
+
+    private function renderOpenApi(...$openApiRenderer): void
+    {
+        $spec = $this->createMock(OpenApi::class);
+        $generator = new class($spec) {
+            private $spec;
+
+            public function __construct($spec)
+            {
+                $this->spec = $spec;
+            }
+
+            public function generate()
+            {
+                return $this->spec;
+            }
+        };
+
+        $generatorLocator = $this->createMock(ContainerInterface::class);
+        $generatorLocator->method('has')->willReturn($this->hasArea);
+        $generatorLocator->method('get')->willReturn($generator);
+
+        $renderOpenApi = new RenderOpenApi($generatorLocator, ...$openApiRenderer);
+        $renderOpenApi->render($this->format, $this->area, []);
+    }
+}