From 7a7634fba664249a04fc771df677a9b9f755d7ec Mon Sep 17 00:00:00 2001 From: Mark Baker Date: Fri, 24 May 2013 12:57:42 +0100 Subject: [PATCH] Only read first 8 bytes of a file when validating, rather than load the entire file into memory at that point --- Classes/PHPExcel/Shared/OLERead.php | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Classes/PHPExcel/Shared/OLERead.php b/Classes/PHPExcel/Shared/OLERead.php index 55ed7e0..30e12a4 100644 --- a/Classes/PHPExcel/Shared/OLERead.php +++ b/Classes/PHPExcel/Shared/OLERead.php @@ -80,14 +80,18 @@ class PHPExcel_Shared_OLERead { throw new PHPExcel_Reader_Exception("Could not open " . $sFileName . " for reading! File does not exist, or it is not readable."); } - // Get the file data - $this->data = file_get_contents($sFileName); + // Get the file identifier + // Don't bother reading the whole file until we know it's a valid OLE file + $this->data = file_get_contents($sFileName, FALSE, NULL, 0, 8); // Check OLE identifier - if (substr($this->data, 0, 8) != self::IDENTIFIER_OLE) { + if ($this->data != self::IDENTIFIER_OLE) { throw new PHPExcel_Reader_Exception('The filename ' . $sFileName . ' is not recognised as an OLE file'); } + // Get the file data + $this->data = file_get_contents($sFileName); + // Total number of sectors used for the SAT $this->numBigBlockDepotBlocks = self::_GetInt4d($this->data, self::NUM_BIG_BLOCK_DEPOT_BLOCKS_POS);