RetailCRM-Mirror/api-client-go
1
0
Fork 0
mirror of https://github.com/retailcrm/api-client-go.git synced 2025-04-03 13:13:37 +03:00
Code Issues Projects Releases Wiki Activity

update linter action config & fix for tests

Browse source
This commit is contained in:
Pavel 2021-04-16 12:16:09 +03:00
parent d551e91985
commit f4e95c9423
3 changed files with 15 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
.github/workflows/ci.yml vendored
View file

@ -28,15 +28,19 @@ jobs:
- name: Get dependencies
run: |
go get -v github.com/google/go-querystring/query
go get -v github.com/h2non/gock
go get -v gopkg.in/h2non/gock.v1
go get -v github.com/joho/godotenv
go get -v github.com/retailcrm/api-client-go/errs
cp .env.dist .env
- name: Lint code with golangci-lint
uses: golangci/golangci-lint-action@v2
env:
GO111MODULE: off
with:
version: v1.36
version: v1.39
only-new-issues: true
skip-go-installation: true
skip-pkg-cache: true
tests:
name: Tests
runs-on: ubuntu-latest
@ -56,7 +60,7 @@ jobs:
- name: Get dependencies
run: |
go get -v github.com/google/go-querystring/query
go get -v github.com/h2non/gock
go get -v gopkg.in/h2non/gock.v1
go get -v github.com/joho/godotenv
go get -v github.com/retailcrm/api-client-go/errs
cp .env.dist .env

6
v5/client.go
View file

@ -617,7 +617,7 @@ func (c *Client) CustomerNoteDelete(id int) (SuccessfulResponse, int, *errs.Fail
var resp SuccessfulResponse
p := url.Values{
"id": {string(id)},
"id": {strconv.Itoa(id)},
}
data, status, err := c.PostRequest(fmt.Sprintf("/customers/notes/%d/delete", id), p)
@ -1106,7 +1106,7 @@ func (c *Client) CorporateCustomerNoteDelete(id int) (SuccessfulResponse, int, *
var resp SuccessfulResponse
p := url.Values{
"id": {string(id)},
"id": {strconv.Itoa(id)},
}
data, status, err := c.PostRequest(fmt.Sprintf("/customers-corporate/notes/%d/delete", id), p)
@ -2437,7 +2437,7 @@ func (c *Client) OrderPaymentDelete(id int) (SuccessfulResponse, int, *errs.Fail
var resp SuccessfulResponse
p := url.Values{
"id": {string(id)},
"id": {strconv.Itoa(id)},
}
data, status, err := c.PostRequest(fmt.Sprintf("/orders/payments/%d/delete", id), p)

10
v5/client_test.go
View file

@ -15,8 +15,8 @@ import (
"testing"
"time"
"github.com/h2non/gock"
"github.com/joho/godotenv"
"gopkg.in/h2non/gock.v1"
)
func TestMain(m *testing.M) {
@ -1817,7 +1817,7 @@ func TestClient_NotesCreateDelete(t *testing.T) {
}
p = url.Values{
"id": {string(1)},
"id": {"1"},
}
gock.New(crmURL).
@ -1879,7 +1879,7 @@ func TestClient_NotesCreateDelete_Fail(t *testing.T) {
}
p = url.Values{
"id": {string(iCodeFail)},
"id": {strconv.Itoa(iCodeFail)},
}
gock.New(crmURL).
@ -2564,7 +2564,7 @@ func TestClient_PaymentCreateEditDelete(t *testing.T) {
}
p = url.Values{
"id": {string(paymentCreateResponse.ID)},
"id": {strconv.Itoa(paymentCreateResponse.ID)},
}
gock.New(crmURL).
@ -2655,7 +2655,7 @@ func TestClient_PaymentCreateEditDelete_Fail(t *testing.T) {
}
p = url.Values{
"id": {string(iCodeFail)},
"id": {strconv.Itoa(iCodeFail)},
}
gock.New(crmURL).