From 0cda3678022a53da8e8668e75b202f82ad14b538 Mon Sep 17 00:00:00 2001
From: romanb <romanb@625475ce-881a-0410-a577-b389adb331d8>
Date: Sat, 24 Nov 2007 19:08:41 +0000
Subject: [PATCH] moved tokenizeQuery() to the Tokenizer

---
 lib/Doctrine/Query.php           | 71 +-------------------------------
 lib/Doctrine/Query/Tokenizer.php |  4 +-
 2 files changed, 4 insertions(+), 71 deletions(-)

diff --git a/lib/Doctrine/Query.php b/lib/Doctrine/Query.php
index 3228f96ff..3c3e4cba9 100644
--- a/lib/Doctrine/Query.php
+++ b/lib/Doctrine/Query.php
@@ -1382,73 +1382,6 @@ class Doctrine_Query extends Doctrine_Query_Abstract implements Countable, Seria
         return $subquery;
     }
 
-    /**
-     * tokenizeQuery
-     * splits the given dql query into an array where keys
-     * represent different query part names and values are
-     * arrays splitted using sqlExplode method
-     *
-     * example:
-     *
-     * parameter:
-     *      $query = "SELECT u.* FROM User u WHERE u.name LIKE ?"
-     * returns:
-     *      array('select' => array('u.*'),
-     *            'from'   => array('User', 'u'),
-     *            'where'  => array('u.name', 'LIKE', '?'))
-     *
-     * @param string $query                 DQL query
-     * @throws Doctrine_Query_Exception     if some generic parsing error occurs
-     * @return array                        an array containing the query string parts
-     */
-    public function tokenizeQuery($query)
-    {
-        $parts = array();
-        $tokens = $this->_tokenizer->sqlExplode($query, ' ');
-
-        foreach ($tokens as $index => $token) {
-            $token = trim($token);
-            switch (strtolower($token)) {
-                case 'delete':
-                case 'update':
-                case 'select':
-                case 'set':
-                case 'from':
-                case 'where':
-                case 'limit':
-                case 'offset':
-                case 'having':
-                    $p = $token;
-                    //$parts[$token] = array();
-                    $parts[$token] = '';
-                break;
-                case 'order':
-                case 'group':
-                    $i = ($index + 1);
-                    if (isset($tokens[$i]) && strtolower($tokens[$i]) === 'by') {
-                        $p = $token;
-                        $parts[$token] = '';
-                        //$parts[$token] = array();
-                    } else {
-                        $parts[$p] .= "$token ";
-                        //$parts[$p][] = $token;
-                    }
-                break;
-                case 'by':
-                    continue;
-                default:
-                    if ( ! isset($p)) {
-                        throw new Doctrine_Query_Tokenizer_Exception(
-                                "Couldn't tokenize query. Encountered invalid token: '$token'.");
-                    }
-
-                    $parts[$p] .= "$token ";
-                    //$parts[$p][] = $token;
-            }
-        }
-        return $parts;
-    }
-
     /**
      * DQL PARSER
      * parses a DQL query
@@ -1470,7 +1403,7 @@ class Doctrine_Query extends Doctrine_Query_Abstract implements Countable, Seria
         $query = str_replace("\n", ' ', $query);
         $query = str_replace("\r", ' ', $query);
 
-        $parts = $this->tokenizeQuery($query);
+        $parts = $this->_tokenizer->tokenizeQuery($query);
 
         foreach ($parts as $partName => $subParts) {
             $subParts = trim($subParts);
@@ -1514,7 +1447,7 @@ class Doctrine_Query extends Doctrine_Query_Abstract implements Countable, Seria
     }
     
     /**
-     * @todo DESCRIBE ME! REFACTOR ME! I'M FAR TOO LONG AND COMPLEX! HARD TO UNDERSTAND!
+     * @todo Describe & refactor... too long and nested.
      */
     public function load($path, $loadFields = true)
     {
diff --git a/lib/Doctrine/Query/Tokenizer.php b/lib/Doctrine/Query/Tokenizer.php
index 33f76d042..8621412ae 100644
--- a/lib/Doctrine/Query/Tokenizer.php
+++ b/lib/Doctrine/Query/Tokenizer.php
@@ -61,8 +61,8 @@ class Doctrine_Query_Tokenizer
         $tokens = $this->sqlExplode($query, ' ');
 
         foreach ($tokens as $index => $token) {
-            $token = strtolower(trim($token));
-            switch ($token) {
+            $token = trim($token);
+            switch (strtolower($token)) {
                 case 'delete':
                 case 'update':
                 case 'select':