RetailCRM-Mirror/doctrine2
1
0
Fork 0
mirror of synced 2025-04-03 13:23:37 +03:00
Code Issues Projects Releases Wiki Activity

#1120 - avoiding mutable state for rows/output

Browse source
This commit is contained in:
Marco Pivetta 2014-10-19 18:32:12 +02:00
parent 250b38710c
commit 254a46e79c
1 changed files with 60 additions and 42 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

102
lib/Doctrine/ORM/Tools/Console/Command/MappingDescribeCommand.php
View file

@ -93,47 +93,51 @@ EOT
*/ */
private function displayEntity($entityName, EntityManagerInterface $entityManager, OutputInterface $output) private function displayEntity($entityName, EntityManagerInterface $entityManager, OutputInterface $output)
{ {
$meta = $this->getClassMetadata($entityName, $entityManager); $metadata = $this->getClassMetadata($entityName, $entityManager);
$this->formatField('Name', $meta->name); $rows = array(
$this->formatField('Root entity name', $meta->rootEntityName); $this->formatField('Name', $metadata->name),
$this->formatField('Custom generator definition', $meta->customGeneratorDefinition); $this->formatField('Root entity name', $metadata->rootEntityName),
$this->formatField('Custom repository class', $meta->customRepositoryClassName); $this->formatField('Custom generator definition', $metadata->customGeneratorDefinition),
$this->formatField('Mapped super class?', $meta->isMappedSuperclass); $this->formatField('Custom repository class', $metadata->customRepositoryClassName),
$this->formatField('Embedded class?', $meta->isEmbeddedClass); $this->formatField('Mapped super class?', $metadata->isMappedSuperclass),
$this->formatField('Parent classes', $meta->parentClasses); $this->formatField('Embedded class?', $metadata->isEmbeddedClass),
$this->formatField('Sub classes', $meta->subClasses); $this->formatField('Parent classes', $metadata->parentClasses),
$this->formatField('Embedded classes', $meta->subClasses); $this->formatField('Sub classes', $metadata->subClasses),
$this->formatField('Named queries', $meta->namedQueries); $this->formatField('Embedded classes', $metadata->subClasses),
$this->formatField('Named native queries', $meta->namedNativeQueries); $this->formatField('Named queries', $metadata->namedQueries),
$this->formatField('SQL result set mappings', $meta->sqlResultSetMappings); $this->formatField('Named native queries', $metadata->namedNativeQueries),
$this->formatField('Identifier', $meta->identifier); $this->formatField('SQL result set mappings', $metadata->sqlResultSetMappings),
$this->formatField('Inheritance type', $meta->inheritanceType); $this->formatField('Identifier', $metadata->identifier),
$this->formatField('Discriminator column', $meta->discriminatorColumn); $this->formatField('Inheritance type', $metadata->inheritanceType),
$this->formatField('Discriminator value', $meta->discriminatorValue); $this->formatField('Discriminator column', $metadata->discriminatorColumn),
$this->formatField('Discriminator map', $meta->discriminatorMap); $this->formatField('Discriminator value', $metadata->discriminatorValue),
$this->formatField('Generator type', $meta->generatorType); $this->formatField('Discriminator map', $metadata->discriminatorMap),
$this->formatField('Table', $meta->table); $this->formatField('Generator type', $metadata->generatorType),
$this->formatField('Composite identifier?', $meta->isIdentifierComposite); $this->formatField('Table', $metadata->table),
$this->formatField('Foreign identifier?', $meta->containsForeignIdentifier); $this->formatField('Composite identifier?', $metadata->isIdentifierComposite),
$this->formatField('Sequence generator definition', $meta->sequenceGeneratorDefinition); $this->formatField('Foreign identifier?', $metadata->containsForeignIdentifier),
$this->formatField('Table generator definition', $meta->tableGeneratorDefinition); $this->formatField('Sequence generator definition', $metadata->sequenceGeneratorDefinition),
$this->formatField('Change tracking policy', $meta->changeTrackingPolicy); $this->formatField('Table generator definition', $metadata->tableGeneratorDefinition),
$this->formatField('Versioned?', $meta->isVersioned); $this->formatField('Change tracking policy', $metadata->changeTrackingPolicy),
$this->formatField('Version field', $meta->versionField); $this->formatField('Versioned?', $metadata->isVersioned),
$this->formatField('Read only?', $meta->isReadOnly); $this->formatField('Version field', $metadata->versionField),
$this->formatField('Read only?', $metadata->isReadOnly),
$this->formatEntityListeners($meta->entityListeners); $this->formatEntityListeners($metadata->entityListeners),
$this->formatAssociationMappings($meta->associationMappings); );
$this->formatFieldMappings($meta->fieldMappings);
$rows = array_merge(
$rows,
$this->formatAssociationMappings($metadata->associationMappings),
$this->formatFieldMappings($metadata->fieldMappings)
);
$table = new Table($output); $table = new Table($output);
$table->setHeaders(array('Field', 'Value')); $table->setHeaders(array('Field', 'Value'));
foreach ($this->out as $tuple) { array_map(array($table, 'addRow'), $rows);
$table->addRow($tuple);
}
$table->render(); $table->render();
} }
@ -255,6 +259,8 @@ EOT
* *
* @param string $label Label for the value * @param string $label Label for the value
* @param mixed $value A Value to show * @param mixed $value A Value to show
*
* @return array
*/ */
private function formatField($label, $value) private function formatField($label, $value)
{ {
@ -262,31 +268,38 @@ EOT
$value = '<comment>None</comment>'; $value = '<comment>None</comment>';
} }
$this->out[] = array(sprintf('<info>%s</info>', $label), $this->formatValue($value)); return array(sprintf('<info>%s</info>', $label), $this->formatValue($value));
} }
/** /**
* Format the association mappings * Format the association mappings
* *
* @param array * @param array
*
* @return array
*/ */
private function formatAssociationMappings($associationMappings) private function formatAssociationMappings($associationMappings)
{ {
$this->formatField('Association mappings:', ''); $output = array();
$output[] = $this->formatField('Association mappings:', '');
foreach ($associationMappings as $associationName => $mapping) { foreach ($associationMappings as $associationName => $mapping) {
$this->formatField(sprintf(' %s', $associationName), ''); $output[] = $this->formatField(sprintf(' %s', $associationName), '');
foreach ($mapping as $field => $value) { foreach ($mapping as $field => $value) {
$this->formatField(sprintf(' %s', $field), $this->formatValue($value)); $output[] = $this->formatField(sprintf(' %s', $field), $this->formatValue($value));
} }
} }
return $output;
} }
/** /**
* Format the entity listeners * Format the entity listeners
* *
* @param array $entityListeners * @param array $entityListeners
*
* @return array
*/ */
private function formatEntityListeners($entityListeners) private function formatEntityListeners($entityListeners)
{ {
@ -296,24 +309,29 @@ EOT
$entityListenerNames[] = get_class($entityListener); $entityListenerNames[] = get_class($entityListener);
} }
$this->formatField('Entity listeners', $entityListenerNames); return $this->formatField('Entity listeners', $entityListenerNames);
} }
/** /**
* Form the field mappings * Form the field mappings
* *
* @param array $fieldMappings * @param array $fieldMappings
*
* @return array
*/ */
private function formatFieldMappings($fieldMappings) private function formatFieldMappings($fieldMappings)
{ {
$this->formatField('Field mappings:', ''); $output = array();
$output[] = $this->formatField('Field mappings:', '');
foreach ($fieldMappings as $fieldName => $mapping) { foreach ($fieldMappings as $fieldName => $mapping) {
$this->formatField(sprintf(' %s',$fieldName), ''); $output[] = $this->formatField(sprintf(' %s',$fieldName), '');
foreach ($mapping as $field => $value) { foreach ($mapping as $field => $value) {
$this->formatField(sprintf(' %s', $field), $this->formatValue($value)); $output[] = $this->formatField(sprintf(' %s', $field), $this->formatValue($value));
} }
} }
return $output;
} }
} }