RetailCRM-Mirror/doctrine2
1
0
Fork 0
mirror of synced 2025-04-03 13:23:37 +03:00
Code Issues Projects Releases Wiki Activity

Remove call to EntityManager#flush() if the unitofwork contains pending insertions. Flush should always be triggered explicitly.

Browse source
This commit is contained in:
Benjamin Eberlei 2010-12-11 00:54:54 +01:00
parent 4f154b6aa1
commit 3c0f92f4c7
1 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/Doctrine/ORM/AbstractQuery.php
View file

@ -482,15 +482,6 @@ abstract class AbstractQuery
*/ */
public function execute($params = array(), $hydrationMode = null) public function execute($params = array(), $hydrationMode = null)
{ {
// If there are still pending insertions in the UnitOfWork we need to flush
// in order to guarantee a correct result.
//TODO: Think this over. Its tricky. Not doing this can lead to strange results
// potentially, but doing it could result in endless loops when querying during
// a flush, i.e. inside an event listener.
if ($this->_em->getUnitOfWork()->hasPendingInsertions()) {
$this->_em->flush();
}
if ($hydrationMode !== null) { if ($hydrationMode !== null) {
$this->setHydrationMode($hydrationMode); $this->setHydrationMode($hydrationMode);
} }