RetailCRM-Mirror/doctrine2
1
0
Fork 0
mirror of synced 2025-04-03 13:23:37 +03:00
Code Issues Projects Releases Wiki Activity

Fixed bug on columns not being quoted on INSERT statements, reported by email by Gavin Mogan

Browse source
This commit is contained in:
jackbravo 2007-08-25 00:34:25 +00:00
parent d47b8f11ec
commit 777539fbf3
1 changed files with 13 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
lib/Doctrine/Connection.php
View file

@ -468,25 +468,26 @@ abstract class Doctrine_Connection extends Doctrine_Configurable implements Coun
if (empty($values)) { if (empty($values)) {
return false; return false;
} }
// column names are specified as array keys // column names are specified as array keys
$cols = array_keys($values); $cols = array();
// the query VALUES will contain either expresions (eg 'NOW()') or ?
$a = array();
foreach ($values as $k => $value) {
$cols[] = $this->quoteIdentifier($k);
if ($value instanceof Doctrine_Expression) {
$a[] = $value->getSql();
unset($values[$k]);
} else {
$a[] = '?';
}
}
// build the statement // build the statement
$query = 'INSERT INTO ' . $this->quoteIdentifier($table) $query = 'INSERT INTO ' . $this->quoteIdentifier($table)
. ' (' . implode(', ', $cols) . ') ' . ' (' . implode(', ', $cols) . ') '
. 'VALUES ('; . 'VALUES (';
$a = array();
foreach ($values as $k => $value) {
if ($value instanceof Doctrine_Expression) {
$value = $value->getSql();
unset($values[$k]);
} else {
$value = '?';
}
$a[] = $value;
}
$query .= implode(', ', $a) . ')'; $query .= implode(', ', $a) . ')';
// prepare and execute the statement // prepare and execute the statement