From 93c018668d33ce8f3d9d7673690901e1df773bce Mon Sep 17 00:00:00 2001 From: catalin Date: Tue, 6 Nov 2012 22:38:46 +0200 Subject: [PATCH] checking preg result. Should I raise an error throw new ORMException("Error regular expression: " . $filter); --- lib/Doctrine/ORM/Tools/Console/MetadataFilter.php | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/Doctrine/ORM/Tools/Console/MetadataFilter.php b/lib/Doctrine/ORM/Tools/Console/MetadataFilter.php index 92a4a6b58..1d3764700 100644 --- a/lib/Doctrine/ORM/Tools/Console/MetadataFilter.php +++ b/lib/Doctrine/ORM/Tools/Console/MetadataFilter.php @@ -76,7 +76,16 @@ class MetadataFilter extends \FilterIterator implements \Countable $metadata = $it->current(); foreach ($this->filter as $filter) { - if (preg_match("/" . preg_quote($filter) . "/", $metadata->name)) { + $pregResult = preg_match("/" . preg_quote($filter) . "/", $metadata->name); + if ($pregResult === false) { + return false; + } + + if ($pregResult === 0) { + return false; + } + + if ($pregResult) { return true; } }