RetailCRM-Mirror/doctrine2
1
0
Fork 0
mirror of synced 2025-04-03 05:13:37 +03:00
Code Issues Projects Releases Wiki Activity

#1169 DDC-3343 - correcting one-to-many persister - association should not be updated directly if no orphan removal is involved

Browse source
This commit is contained in:
Marco Pivetta 2015-01-27 06:27:37 +01:00
parent 539c364ca6
commit 9eaac13615
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/Doctrine/ORM/Persisters/Collection/OneToManyPersister.php
View file

@ -157,11 +157,17 @@ class OneToManyPersister extends AbstractCollectionPersister
*/ */
public function removeElement(PersistentCollection $collection, $element) public function removeElement(PersistentCollection $collection, $element)
{ {
$mapping = $collection->getMapping();
if ( ! $mapping['orphanRemoval']) {
// no-op: this is not the owning side, therefore no operations should be applied
return false;
}
if ( ! $this->isValidEntityState($element)) { if ( ! $this->isValidEntityState($element)) {
return false; return false;
} }
$mapping = $collection->getMapping();
$persister = $this->uow->getEntityPersister($mapping['targetEntity']); $persister = $this->uow->getEntityPersister($mapping['targetEntity']);
$targetMetadata = $this->em->getClassMetadata($mapping['targetEntity']); $targetMetadata = $this->em->getClassMetadata($mapping['targetEntity']);