RetailCRM-Mirror/doctrine2
1
0
Fork 0
mirror of synced 2025-04-01 20:36:14 +03:00
Code Issues Projects Releases Wiki Activity

[QueryBuilder] Remove unused method parameters that are shadowed by local variables

Browse source 
PHP5 treats the left part of such assignment as an independent local variable, while HHVM treats it as a reference to the method parameter. This leads to the value of the parameter being changed, which, in turn, causes func_get_args() to return not what is expected.
This commit is a part of the effort to make Symfony run flawlessly on HHVM. This issue causes a bunch of Symfony tests to fail on HHVM.
This commit is contained in:
Alex Bakhturin 2014-10-17 11:17:33 -07:00
parent f5ecabbc21
commit b33c9befb7
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/Doctrine/ORM/QueryBuilder.php
View file

@ -1026,7 +1026,7 @@ class QueryBuilder
*
* @see where()
*/
public function andWhere($where)
public function andWhere()
{
$args = func_get_args();
$where = $this->getDQLPart('where');
@ -1059,7 +1059,7 @@ class QueryBuilder
*
* @see where()
*/
public function orWhere($where)
public function orWhere()
{
$args = func_get_args();
$where = $this->getDqlPart('where');