From df6a41136580528c415909df82a90ba28298acd2 Mon Sep 17 00:00:00 2001
From: Marco Pivetta <ocramius@gmail.com>
Date: Thu, 10 Apr 2014 04:18:18 +0200
Subject: [PATCH] DDC-3078 - cache instantiator is used in the ORM instead of
 callables

---
 lib/Doctrine/ORM/Cache/CacheConfiguration.php | 25 +++++--------------
 lib/Doctrine/ORM/EntityManager.php            |  3 +--
 .../Tests/ORM/Cache/CacheConfigTest.php       | 19 ++------------
 3 files changed, 9 insertions(+), 38 deletions(-)

diff --git a/lib/Doctrine/ORM/Cache/CacheConfiguration.php b/lib/Doctrine/ORM/Cache/CacheConfiguration.php
index 512caa98e..eab36e393 100644
--- a/lib/Doctrine/ORM/Cache/CacheConfiguration.php
+++ b/lib/Doctrine/ORM/Cache/CacheConfiguration.php
@@ -53,7 +53,7 @@ class CacheConfiguration
     private $queryValidator;
 
     /**
-     * @var callable|null
+     * @var CacheInstantiator|null
      */
     private $cacheInstantiator;
 
@@ -132,31 +132,18 @@ class CacheConfiguration
     }
 
     /**
-     * @param callable $instantiator responsible of retrieving an {@see \Doctrine\ORM\Cache} instance given
-     *                               a {@see \Doctrine\ORM\EntityManagerInterface} instance
-     *
-     * @throws ORMException if the given instantiator is not a valid callable
+     * @param CacheInstantiator
      */
-    public function setCacheInstantiator($instantiator)
+    public function setCacheInstantiator(CacheInstantiator $cacheInstantiator)
     {
-        if ( ! is_callable($instantiator)) {
-            throw ORMException::invalidSecondLevelCacheInstantiator($instantiator);
-        }
-
-        $this->cacheInstantiator = $instantiator;
+        $this->cacheInstantiator = $cacheInstantiator;
     }
 
     /**
-     * @return callable that
+     * @return CacheInstantiator
      */
     public function getCacheInstantiator()
     {
-        if ( ! $this->cacheInstantiator) {
-            $this->cacheInstantiator = function (EntityManagerInterface $entityManager) {
-                return new DefaultCache($entityManager);
-            };
-        }
-
-        return $this->cacheInstantiator;
+        return $this->cacheInstantiator ?: $this->cacheInstantiator = new DefaultCacheInstantiator();
     }
 }
diff --git a/lib/Doctrine/ORM/EntityManager.php b/lib/Doctrine/ORM/EntityManager.php
index 175e3108e..5c8ce598b 100644
--- a/lib/Doctrine/ORM/EntityManager.php
+++ b/lib/Doctrine/ORM/EntityManager.php
@@ -166,8 +166,7 @@ use Doctrine\Common\Util\ClassUtils;
         );
 
         if ($config->isSecondLevelCacheEnabled()) {
-            $cacheInstantiator = $config->getSecondLevelCacheConfiguration()->getCacheInstantiator();
-            $this->cache       = $cacheInstantiator($this);
+            $this->cache = $config->getSecondLevelCacheConfiguration()->getCacheInstantiator()->getCache($this);
         }
     }
 
diff --git a/tests/Doctrine/Tests/ORM/Cache/CacheConfigTest.php b/tests/Doctrine/Tests/ORM/Cache/CacheConfigTest.php
index a12f94ec4..dafcd234c 100644
--- a/tests/Doctrine/Tests/ORM/Cache/CacheConfigTest.php
+++ b/tests/Doctrine/Tests/ORM/Cache/CacheConfigTest.php
@@ -32,18 +32,7 @@ class CacheConfigTest extends DoctrineTestCase
      */
     public function testGetDefaultCacheIstantiator()
     {
-        $entityManager = $this->getMock('Doctrine\ORM\EntityManagerInterface');
-        $config        = $this->getMock('Doctrine\ORM\Configuration');
-
-        $entityManager->expects($this->any())->method('getConfiguration')->will($this->returnValue($config));
-        $config
-            ->expects($this->any())
-            ->method('getSecondLevelCacheConfiguration')
-            ->will($this->returnValue($this->config));
-
-        $defaultIstantiator = $this->config->getCacheInstantiator();
-
-        $this->assertInstanceOf('Doctrine\ORM\Cache\DefaultCache', $defaultIstantiator($entityManager));
+        $this->assertInstanceOf('Doctrine\ORM\Cache\DefaultInstantiator', $this->config->getCacheInstantiator());
     }
 
     /**
@@ -51,14 +40,10 @@ class CacheConfigTest extends DoctrineTestCase
      */
     public function testSetGetCacheIstantiator()
     {
-        $istantiator = function () {};
+        $istantiator = $this->getMock('Doctrine\ORM\Cache\CacheInstantiator');
 
         $this->config->setCacheInstantiator($istantiator);
         $this->assertSame($istantiator, $this->config->getCacheInstantiator());
-
-        $this->setExpectedException('Doctrine\ORM\ORMException');
-
-        $this->config->setCacheInstantiator(null);
     }
 
     public function testSetGetRegionLifetime()