From e9fd5678a566fc4314ceda7967a3c4efbc8d49b5 Mon Sep 17 00:00:00 2001
From: Marco Pivetta <ocramius@gmail.com>
Date: Sat, 17 Jan 2015 08:30:16 +0100
Subject: [PATCH] #1206 DDC-3430 - `PersistentCollection` should not mutate the
 given `Criteria` instances when `matching()`

---
 .../Functional/PersistentCollectionTest.php   | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/tests/Doctrine/Tests/ORM/Functional/PersistentCollectionTest.php b/tests/Doctrine/Tests/ORM/Functional/PersistentCollectionTest.php
index 375f7d3f9..c2181b8b1 100644
--- a/tests/Doctrine/Tests/ORM/Functional/PersistentCollectionTest.php
+++ b/tests/Doctrine/Tests/ORM/Functional/PersistentCollectionTest.php
@@ -2,6 +2,7 @@
 
 namespace Doctrine\Tests\ORM\Functional;
 
+use Doctrine\Common\Collections\Criteria;
 use Doctrine\Common\Persistence\PersistentObject;
 
 /**
@@ -69,6 +70,29 @@ class PersistentCollectionTest extends \Doctrine\Tests\OrmFunctionalTestCase
         $this->assertFalse($collection->isEmpty());
         $this->assertFalse($collection->isInitialized());
     }
+
+    /**
+     * @group #1206
+     * @group DDC-3430
+     */
+    public function testMatchingDoesNotModifyTheGivenCriteria()
+    {
+        $collectionHolder = new PersistentCollectionHolder();
+
+        $this->_em->persist($collectionHolder);
+        $this->_em->flush();
+        $this->_em->clear();
+
+        $criteria = new Criteria();
+
+        $collectionHolder = $this->_em->find(__NAMESPACE__ . '\PersistentCollectionHolder', $collectionHolder->getId());
+        $collectionHolder->getCollection()->matching($criteria);
+
+        $this->assertEmpty($criteria->getWhereExpression());
+        $this->assertEmpty($criteria->getFirstResult());
+        $this->assertEmpty($criteria->getMaxResults());
+        $this->assertEmpty($criteria->getOrderings());
+    }
 }
 
 /**