RetailCRM-Mirror/doctrine2
1
0
Fork 0
mirror of synced 2025-04-04 05:43:36 +03:00
Code Issues Projects Releases Wiki Activity
Doctrine 2 Object Relational Mapper (ORM)
11237 commits 5 branches 0 tags 33 MiB
Find a file
Marco Pivetta 960a437d46 #7527 failing test case: UnitOfWork#getSingleIdentifierValue() should not be called for a well specified parameter type 
As previously reported by @flaushi in https://github.com/doctrine/doctrine2/pull/7471#discussion_r241949045, we discovered
that binding a parameter causes a `ClassMetadataFactory#getClassMetadata()` call, which in turn leads to large performance
regression when using any `object` type as parameter.

Following two snippets lead to an internal `ClassMetadataFactory#getClassMetadata()` call, which in turn leads to an
exception being thrown and garbage collected, plus multiple associated performance implications:

```php
$query->setParameter('foo', new DateTime());
$query->getResult();
```

```php
$query->setParameter('foo', new DateTime(), DateTimeType::NAME);
$query->getResult();
```

This is due to following portion of code:

434820973c/lib/Doctrine/ORM/Query.php (L406-L409)

Notice how `$value = $this->processParameterValue($value);` happens before attempting to infer the type for the parameter value.

That call leads to this segment being reached, which leads to the regression:

434820973c/lib/Doctrine/ORM/AbstractQuery.php (L423-L433)

Assuming the bound parameter type is provided, we can completely skip attempting to introspect the given object:

```php
$query->setParameter('foo', new DateTime(), DateTimeType::NAME);
$query->getResult();
```

Processing the parameter value is not needed in this case, so we can safely skip that logic for all known parameters.
In order to not introduce a BC break or change the `AbstractQuery#processParameterValue()` implementation, we could filter
out all parameters for which the type is given upfront, and later on merge them back in instead.

The test expectation to be set is for `UnitOfWork#getSingleIdentifierValue()` to never be called.
2018-12-16 15:37:45 +01:00
bin Use short-array syntax on "bin" directory 2016-12-07 23:34:14 +01:00
docs Merge pull request #7521 from doctrine/update-chat-link 2018-12-12 20:07:31 +00:00
lib/Doctrine/ORM 7518 Fixed PHPDoc Error. 2018-12-12 17:08:35 +03:00
tests #7527 failing test case: UnitOfWork#getSingleIdentifierValue() should not be called for a well specified parameter type 2018-12-16 15:37:45 +01:00
tools/sandbox Use HTTPS endpoint for XML schema location 2018-11-12 11:29:32 +01:00
.gitattributes Add configuration for PHPCS 2017-11-23 11:26:33 +01:00
.gitignore Lock dependencies for Code Quality stage 2018-12-10 13:58:51 +01:00
.gitmodules Removing submodules as of doctrine/doctrine2#570 2013-02-15 18:33:29 +01:00
.scrutinizer.yml Use new analyser on scrutinizer-ci 2017-11-23 10:24:18 +01:00
.travis.yml Lock dependencies for Code Quality stage 2018-12-10 13:58:51 +01:00
build.properties New Build process 2013-09-07 12:56:49 +02:00
build.properties.dev Add support to distribute the XSD to a given directory during build process 2011-08-27 13:23:17 +02:00
build.xml New Build process 2013-09-07 12:56:49 +02:00
composer.json Update doctrine/coding-standard in 2.x branch 2018-12-10 13:58:51 +01:00
composer.lock Lock dependencies for Code Quality stage 2018-12-10 13:58:51 +01:00
CONTRIBUTING.md Removing section about jira as it has been removed. 2016-02-17 11:02:19 +01:00
doctrine-mapping.xsd Re-order attributes of relation complex types 2017-12-17 02:36:41 +01:00
LICENSE Updated year range 2015-09-29 22:52:45 +00:00
phpbench.json PHPBench base config 2017-07-23 10:16:17 +02:00
phpcs.xml.dist Update doctrine/coding-standard in 2.x branch 2018-12-10 13:58:51 +01:00
phpstan.neon Setup: Switch Apc -> Apcu and Memcache -> Memcached 2017-12-19 02:43:03 +01:00
phpunit.xml.dist Use SymfonyStyle for command output 2017-11-24 01:25:17 +01:00
README.md README: Fix PHP version 2017-12-16 22:05:22 +01:00
run-all.sh Fixed typos 2013-03-11 00:08:58 +00:00
SECURITY.md Add SECURITY.md and a chapter on security assumptions in Doctrine ORM. 2014-02-21 16:12:32 +01:00
UPGRADE.md Add UPGRADE note for EntityRepository::count() 2018-06-27 20:41:59 +02:00

README.md

Master 2.5
Build status Build status
Coverage Status Coverage Status

Doctrine 2 is an object-relational mapper (ORM) for PHP 7.1+ that provides transparent persistence for PHP objects. It sits on top of a powerful database abstraction layer (DBAL). One of its key features is the option to write database queries in a proprietary object oriented SQL dialect called Doctrine Query Language (DQL), inspired by Hibernate's HQL. This provides developers with a powerful alternative to SQL that maintains flexibility without requiring unnecessary code duplication.

More resources: