From 4f8888daedfe0482fb492a158e43c449d08a4f91 Mon Sep 17 00:00:00 2001 From: Artem Bondarenko Date: Sat, 10 Oct 2020 01:22:17 +0300 Subject: [PATCH] domain tracking implementation fix cs --- src/Model/Domain/ClickTracking.php | 5 +---- src/Model/Domain/OpenTracking.php | 5 +---- src/Model/Domain/TrackingResponse.php | 9 --------- src/Model/Domain/UnsubscribeTracking.php | 11 +---------- src/Model/Domain/UpdateClickTrackingResponse.php | 6 ------ src/Model/Domain/UpdateOpenTrackingResponse.php | 6 ------ .../Domain/UpdateUnsubscribeTrackingResponse.php | 6 ------ 7 files changed, 3 insertions(+), 45 deletions(-) diff --git a/src/Model/Domain/ClickTracking.php b/src/Model/Domain/ClickTracking.php index aa31e81..6101604 100644 --- a/src/Model/Domain/ClickTracking.php +++ b/src/Model/Domain/ClickTracking.php @@ -23,7 +23,7 @@ final class ClickTracking public static function create(array $data): self { $model = new self(); - $model->active = !!($data['active'] ?? null); + $model->active = (bool) ($data['active'] ?? null); return $model; } @@ -32,9 +32,6 @@ final class ClickTracking { } - /** - * @return bool - */ public function isActive(): bool { return $this->active; diff --git a/src/Model/Domain/OpenTracking.php b/src/Model/Domain/OpenTracking.php index 54e5dfb..a99febd 100644 --- a/src/Model/Domain/OpenTracking.php +++ b/src/Model/Domain/OpenTracking.php @@ -23,7 +23,7 @@ final class OpenTracking public static function create(array $data): self { $model = new self(); - $model->active = !!($data['active'] ?? null); + $model->active = (bool) ($data['active'] ?? null); return $model; } @@ -32,9 +32,6 @@ final class OpenTracking { } - /** - * @return bool - */ public function isActive(): bool { return $this->active; diff --git a/src/Model/Domain/TrackingResponse.php b/src/Model/Domain/TrackingResponse.php index ebb13e2..0f68805 100644 --- a/src/Model/Domain/TrackingResponse.php +++ b/src/Model/Domain/TrackingResponse.php @@ -42,25 +42,16 @@ final class TrackingResponse implements ApiResponse { } - /** - * @return ClickTracking - */ public function getClick(): ClickTracking { return $this->click; } - /** - * @return OpenTracking - */ public function getOpen(): OpenTracking { return $this->open; } - /** - * @return UnsubscribeTracking - */ public function getUnsubscribe(): UnsubscribeTracking { return $this->unsubscribe; diff --git a/src/Model/Domain/UnsubscribeTracking.php b/src/Model/Domain/UnsubscribeTracking.php index 8974976..e6c5d63 100644 --- a/src/Model/Domain/UnsubscribeTracking.php +++ b/src/Model/Domain/UnsubscribeTracking.php @@ -25,7 +25,7 @@ final class UnsubscribeTracking public static function create(array $data): self { $model = new self(); - $model->active = !!($data['active'] ?? null); + $model->active = (bool) ($data['active'] ?? null); $model->htmlFooter = $data['html_footer'] ?? ''; $model->textFooter = $data['text_footer'] ?? ''; @@ -36,25 +36,16 @@ final class UnsubscribeTracking { } - /** - * @return bool - */ public function isActive(): bool { return $this->active; } - /** - * @return string - */ public function getHtmlFooter(): string { return $this->htmlFooter; } - /** - * @return string - */ public function getTextFooter(): string { return $this->textFooter; diff --git a/src/Model/Domain/UpdateClickTrackingResponse.php b/src/Model/Domain/UpdateClickTrackingResponse.php index 0c085d6..e209df6 100644 --- a/src/Model/Domain/UpdateClickTrackingResponse.php +++ b/src/Model/Domain/UpdateClickTrackingResponse.php @@ -34,17 +34,11 @@ final class UpdateClickTrackingResponse implements ApiResponse { } - /** - * @return string|null - */ public function getMessage(): ?string { return $this->message; } - /** - * @return ClickTracking - */ public function getClick(): ClickTracking { return $this->click; diff --git a/src/Model/Domain/UpdateOpenTrackingResponse.php b/src/Model/Domain/UpdateOpenTrackingResponse.php index b62cf29..7ad0ae0 100644 --- a/src/Model/Domain/UpdateOpenTrackingResponse.php +++ b/src/Model/Domain/UpdateOpenTrackingResponse.php @@ -34,17 +34,11 @@ final class UpdateOpenTrackingResponse implements ApiResponse { } - /** - * @return string|null - */ public function getMessage(): ?string { return $this->message; } - /** - * @return OpenTracking - */ public function getOpen(): OpenTracking { return $this->open; diff --git a/src/Model/Domain/UpdateUnsubscribeTrackingResponse.php b/src/Model/Domain/UpdateUnsubscribeTrackingResponse.php index dc1623e..d6928ba 100644 --- a/src/Model/Domain/UpdateUnsubscribeTrackingResponse.php +++ b/src/Model/Domain/UpdateUnsubscribeTrackingResponse.php @@ -34,17 +34,11 @@ final class UpdateUnsubscribeTrackingResponse implements ApiResponse { } - /** - * @return string|null - */ public function getMessage(): ?string { return $this->message; } - /** - * @return UnsubscribeTracking - */ public function getUnsubscribe(): UnsubscribeTracking { return $this->unsubscribe;