From 4e2fbb8c7a3e634f68aaabbe776f565efcb39cfa Mon Sep 17 00:00:00 2001 From: simus Date: Fri, 9 Jul 2021 17:14:09 +0500 Subject: [PATCH 01/13] changing GraphAPI version to the latest, merging pull request related to Actions --- go.mod | 2 ++ messenger.go | 8 ++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/go.mod b/go.mod index 18da7b6..26c9513 100644 --- a/go.mod +++ b/go.mod @@ -5,6 +5,8 @@ require ( golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7 ) +go 1.16 + require ( github.com/davecgh/go-spew v1.1.1 // indirect github.com/pmezard/go-difflib v1.0.0 // indirect diff --git a/messenger.go b/messenger.go index de7b267..51fb080 100644 --- a/messenger.go +++ b/messenger.go @@ -16,19 +16,19 @@ import ( const ( // ProfileURL is the API endpoint used for retrieving profiles. - // Used in the form: https://graph.facebook.com/v2.6/?fields=&access_token= - ProfileURL = "https://graph.facebook.com/v2.6/" + // Used in the form: https://graph.facebook.com/v11.0/?fields=&access_token= + ProfileURL = "https://graph.facebook.com/v11.0/" // ProfileFields is a list of JSON field names which will be populated by the profile query. ProfileFields = "first_name,last_name,profile_pic" // SendSettingsURL is API endpoint for saving settings. - SendSettingsURL = "https://graph.facebook.com/v2.6/me/thread_settings" + SendSettingsURL = "https://graph.facebook.com/v11.0/me/thread_settings" // MessengerProfileURL is the API endpoint where you set properties that define various aspects of the following Messenger Platform features. // Used in the form https://graph.facebook.com/v2.6/me/messenger_profile?access_token= // https://developers.facebook.com/docs/messenger-platform/reference/messenger-profile-api/ - MessengerProfileURL = "https://graph.facebook.com/v2.6/me/messenger_profile" + MessengerProfileURL = "https://graph.facebook.com/v11.0/me/messenger_profile" ) // Options are the settings used when creating a Messenger client. From 97087a86227f66d884adba0b6eb024c1e447e290 Mon Sep 17 00:00:00 2001 From: Pranas Kiziela Date: Mon, 14 Oct 2019 12:59:51 +0300 Subject: [PATCH 02/13] Add constants for sender actions --- response.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/response.go b/response.go index f0c6970..f2a19c1 100644 --- a/response.go +++ b/response.go @@ -59,6 +59,10 @@ const ( HorizontalImageAspectRatio ImageAspectRatio = "horizontal" // ImageAspectRatio is square. SquareImageAspectRatio ImageAspectRatio = "square" + + SenderActionMarkSeen SenderAction = "mark_seen" + SenderActionTypingOn SenderAction = "typing_on" + SenderActionTypingOff SenderAction = "typing_off" ) // QueryResponse is the response sent back by Facebook when setting up things From 51c7c1bd0e68034352bd4caa9ba537b422198c17 Mon Sep 17 00:00:00 2001 From: simus Date: Thu, 30 Jun 2022 10:04:17 +0500 Subject: [PATCH 03/13] changing GraphAPI version to the latest, merging pull request related to Actions --- messenger.go | 6 +++--- response.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/messenger.go b/messenger.go index 51fb080..21a3456 100644 --- a/messenger.go +++ b/messenger.go @@ -302,9 +302,9 @@ func (m *Messenger) handle(w http.ResponseWriter, r *http.Request) { respond(w, http.StatusBadRequest) return } - - if rec.Object != "page" { - fmt.Println("Object is not page, undefined behavior. Got", rec.Object) + + if rec.Object != "page" && rec.Object != "instagram" { + fmt.Println("Object is not page or instagram, undefined behaviour. Got", rec.Object) respond(w, http.StatusUnprocessableEntity) return } diff --git a/response.go b/response.go index f2a19c1..eb2804a 100644 --- a/response.go +++ b/response.go @@ -24,7 +24,7 @@ type ImageAspectRatio string const ( // DefaultSendAPIVersion is a default Send API version - DefaultSendAPIVersion = "v2.11" + DefaultSendAPIVersion = "v11.0" // SendMessageURL is API endpoint for sending messages. SendMessageURL = "https://graph.facebook.com/%s/me/messages" // ThreadControlURL is the API endpoint for passing thread control. From 457e45b0a8fdc30f7813eacb5fd13be1bea41c7a Mon Sep 17 00:00:00 2001 From: simus Date: Thu, 30 Jun 2022 13:40:12 +0500 Subject: [PATCH 04/13] added additional fields for instagram users, to Profile struct --- profile.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/profile.go b/profile.go index 52e909c..e893121 100644 --- a/profile.go +++ b/profile.go @@ -9,4 +9,10 @@ type Profile struct { Locale string `json:"locale"` Timezone float64 `json:"timezone"` Gender string `json:"gender"` + + // instagram user profile + Username string `json:"username,omitempty"` + IsPrivate bool `json:"is_private,omitempty"` + FollowCount int32 `json:"follow_count,omitempty"` + FollowedByCount int32 `json:"followed_by_count,omitempty"` } From 1c29d3ccd0d27c8641da78fccb0cd6d5e43548f6 Mon Sep 17 00:00:00 2001 From: simus Date: Fri, 1 Jul 2022 14:17:35 +0500 Subject: [PATCH 05/13] changed Profile struct for instagram --- messenger.go | 10 +++++----- profile.go | 11 +++++++---- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/messenger.go b/messenger.go index 21a3456..98d9468 100644 --- a/messenger.go +++ b/messenger.go @@ -15,13 +15,13 @@ import ( ) const ( - // ProfileURL is the API endpoint used for retrieving profiles. - // Used in the form: https://graph.facebook.com/v11.0/?fields=&access_token= - ProfileURL = "https://graph.facebook.com/v11.0/" - // ProfileFields is a list of JSON field names which will be populated by the profile query. ProfileFields = "first_name,last_name,profile_pic" + // ProfileURL is the API endpoint used for retrieving profiles. + // Used in the form: https://graph.facebook.com/v14.0/?fields=&access_token= + ProfileURL = "https://graph.facebook.com/v14.0/" + // SendSettingsURL is API endpoint for saving settings. SendSettingsURL = "https://graph.facebook.com/v11.0/me/thread_settings" @@ -302,7 +302,7 @@ func (m *Messenger) handle(w http.ResponseWriter, r *http.Request) { respond(w, http.StatusBadRequest) return } - + if rec.Object != "page" && rec.Object != "instagram" { fmt.Println("Object is not page or instagram, undefined behaviour. Got", rec.Object) respond(w, http.StatusUnprocessableEntity) diff --git a/profile.go b/profile.go index e893121..d5ae231 100644 --- a/profile.go +++ b/profile.go @@ -11,8 +11,11 @@ type Profile struct { Gender string `json:"gender"` // instagram user profile - Username string `json:"username,omitempty"` - IsPrivate bool `json:"is_private,omitempty"` - FollowCount int32 `json:"follow_count,omitempty"` - FollowedByCount int32 `json:"followed_by_count,omitempty"` + Username string `json:"username,omitempty"` + IsPrivate bool `json:"is_private,omitempty"` + //FollowCount int32 `json:"follow_count,omitempty"` + FollowedByCount int32 `json:"follower_count,omitempty"` // by the documentation followed_by_count + IsVerifiedUser bool `json:"is_verified_user"` + IsUserFollowBusiness bool `json:"is_user_follow_business"` + IsBusinessFollowUser bool `json:"is_business_follow_user"` } From a752143df4f7889e1c723d6be88dbd107e962f15 Mon Sep 17 00:00:00 2001 From: simus Date: Fri, 30 Dec 2022 16:16:19 +0500 Subject: [PATCH 06/13] handling notification_type of the messages --- response.go | 56 +++++++++++++++++++++++++++++++++++++++++------------ 1 file changed, 44 insertions(+), 12 deletions(-) diff --git a/response.go b/response.go index eb2804a..37f20ea 100644 --- a/response.go +++ b/response.go @@ -19,6 +19,7 @@ import ( // AttachmentType is attachment type. type AttachmentType string type MessagingType string +type NotificationType string type TopElementStyle string type ImageAspectRatio string @@ -50,6 +51,13 @@ const ( // NonPromotionalSubscriptionType is NON_PROMOTIONAL_SUBSCRIPTION messaging type. NonPromotionalSubscriptionType MessagingType = "NON_PROMOTIONAL_SUBSCRIPTION" + // NotificationNoPushType is NO_PUSH notification type + NotificationNoPushType NotificationType = "NO_PUSH" + // NotificationRegularType is REGULAR notification type (default) + NotificationRegularType NotificationType = "REGULAR" + // NotificationSilentPushType is SILENT_PUSH notification type + NotificationSilentPushType NotificationType = "SILENT_PUSH" + // TopElementStyle is compact. CompactTopElementStyle TopElementStyle = "compact" // TopElementStyle is large. @@ -127,16 +135,30 @@ func (r *Response) SetToken(token string) { r.token = token } -// Text sends a textual message. -func (r *Response) Text(message string, messagingType MessagingType, metadata string, tags ...string) (QueryResponse, error) { - return r.TextWithReplies(message, nil, messagingType, metadata, tags...) +func (r *Response) Text( + message string, + messagingType MessagingType, + metadata string, + notificationType NotificationType, + tags ...string, +) (QueryResponse, error) { + return r.TextWithReplies(message, nil, messagingType, metadata, notificationType, tags...) } // TextWithReplies sends a textual message with some replies // messagingType should be one of the following: "RESPONSE","UPDATE","MESSAGE_TAG","NON_PROMOTIONAL_SUBSCRIPTION" // only supply tags when messagingType == "MESSAGE_TAG" // (see https://developers.facebook.com/docs/messenger-platform/send-messages#messaging_types for more). -func (r *Response) TextWithReplies(message string, replies []QuickReply, messagingType MessagingType, metadata string, tags ...string) (QueryResponse, error) { +// notificationType should be one of the following: "NO_PUSH","REGULAR" (default),"SILENT_PUSH" +// only supply tags when messagingType == "MESSAGE_TAG" (see https://developers.facebook.com/docs/messenger-platform/send-messages#messaging_types for more) +func (r *Response) TextWithReplies( + message string, + replies []QuickReply, + messagingType MessagingType, + metadata string, + notificationType NotificationType, + tags ...string, +) (QueryResponse, error) { var tag string if len(tags) > 0 { tag = tags[0] @@ -151,13 +173,21 @@ func (r *Response) TextWithReplies(message string, replies []QuickReply, messagi QuickReplies: replies, Metadata: metadata, }, - Tag: tag, + Tag: tag, + NotificationType: notificationType, } return r.DispatchMessage(&m) } -// AttachmentWithReplies sends a attachment message with some replies. -func (r *Response) AttachmentWithReplies(attachment *StructuredMessageAttachment, replies []QuickReply, messagingType MessagingType, metadata string, tags ...string) (QueryResponse, error) { +// AttachmentWithReplies sends a attachment message with some replies +func (r *Response) AttachmentWithReplies( + attachment *StructuredMessageAttachment, + replies []QuickReply, + messagingType MessagingType, + metadata string, + notificationType NotificationType, + tags ...string, +) (QueryResponse, error) { var tag string if len(tags) > 0 { tag = tags[0] @@ -171,7 +201,8 @@ func (r *Response) AttachmentWithReplies(attachment *StructuredMessageAttachment QuickReplies: replies, Metadata: metadata, }, - Tag: tag, + Tag: tag, + NotificationType: notificationType, } return r.DispatchMessage(&m) } @@ -423,10 +454,11 @@ func (r *Response) PassThreadToInbox() error { // SendMessage is the information sent in an API request to Facebook. type SendMessage struct { - MessagingType MessagingType `json:"messaging_type"` - Recipient Recipient `json:"recipient"` - Message MessageData `json:"message"` - Tag string `json:"tag,omitempty"` + MessagingType MessagingType `json:"messaging_type"` + Recipient Recipient `json:"recipient"` + Message MessageData `json:"message"` + Tag string `json:"tag,omitempty"` + NotificationType NotificationType `json:"notification_type,omitempty"` } // MessageData is a message consisting of text or an attachment, with an additional selection of optional quick replies. From 3fa3f4255e665815b154960e6275b409e162a843 Mon Sep 17 00:00:00 2001 From: simus Date: Fri, 30 Dec 2022 16:21:00 +0500 Subject: [PATCH 07/13] added some official docstrings to the NotificationTypes --- response.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/response.go b/response.go index 37f20ea..256b9d5 100644 --- a/response.go +++ b/response.go @@ -51,11 +51,11 @@ const ( // NonPromotionalSubscriptionType is NON_PROMOTIONAL_SUBSCRIPTION messaging type. NonPromotionalSubscriptionType MessagingType = "NON_PROMOTIONAL_SUBSCRIPTION" - // NotificationNoPushType is NO_PUSH notification type + // NotificationNoPushType is NO_PUSH notification type. No notification NotificationNoPushType NotificationType = "NO_PUSH" - // NotificationRegularType is REGULAR notification type (default) + // NotificationRegularType is REGULAR notification type (default). Sound or vibration when a message is received by a person NotificationRegularType NotificationType = "REGULAR" - // NotificationSilentPushType is SILENT_PUSH notification type + // NotificationSilentPushType is SILENT_PUSH notification type. On-screen notification only NotificationSilentPushType NotificationType = "SILENT_PUSH" // TopElementStyle is compact. From 00ef20550085f47ada32e3889ecc3b7555d8a8ef Mon Sep 17 00:00:00 2001 From: simus Date: Fri, 30 Dec 2022 16:30:42 +0500 Subject: [PATCH 08/13] added TagType enum for MESSAGE_TAG messaging type --- response.go | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/response.go b/response.go index 256b9d5..9393e23 100644 --- a/response.go +++ b/response.go @@ -22,6 +22,7 @@ type MessagingType string type NotificationType string type TopElementStyle string type ImageAspectRatio string +type TagType string const ( // DefaultSendAPIVersion is a default Send API version @@ -71,6 +72,17 @@ const ( SenderActionMarkSeen SenderAction = "mark_seen" SenderActionTypingOn SenderAction = "typing_on" SenderActionTypingOff SenderAction = "typing_off" + + // TagAccountUpdateType Tags the message you are sending to your customer as a non-recurring update to their application or account. Not available for Instagram Messaging API + TagAccountUpdateType TagType = "ACCOUNT_UPDATE" + // TagConfirmedEventUpdateType Tags the message you are sending to your customer as a reminder fo an upcoming event or an update for an event in procgres for which the customer is registered. Not available for Instagram Messaging API + TagConfirmedEventUpdateType TagType = "CONFIRMED_EVENT_UPDATE" + // TagCustomerFeedbackType Tags the message you are sending to your customer as a Customer Feedback Survey. Customer feedback messages must be sent within 7 days of the customer's last message. Not available for Instagram Messaging API + TagCustomerFeedbackType TagType = "CUSTOMER_FEEDBACK" + // TagHumanAgentType When this tag is added to a message to a customer, it allows a human agent to respond to a person's message. Messages can be sent within 7 days of the person's. Human agent support is for issues that cannot be resolved within the standard 24 hour messaging window + TagHumanAgentType TagType = "HUMAN_AGENT" + // TagPostPurchaseUpdateType Tags the message you are sending to your customer as an update for a recent purchase made by the customer. Not available for Instagram Messaging API. + TagPostPurchaseUpdateType TagType = "POST_PURCHASE_UPDATE" ) // QueryResponse is the response sent back by Facebook when setting up things @@ -140,7 +152,7 @@ func (r *Response) Text( messagingType MessagingType, metadata string, notificationType NotificationType, - tags ...string, + tags ...TagType, ) (QueryResponse, error) { return r.TextWithReplies(message, nil, messagingType, metadata, notificationType, tags...) } @@ -157,9 +169,9 @@ func (r *Response) TextWithReplies( messagingType MessagingType, metadata string, notificationType NotificationType, - tags ...string, + tags ...TagType, ) (QueryResponse, error) { - var tag string + var tag TagType if len(tags) > 0 { tag = tags[0] } @@ -186,9 +198,9 @@ func (r *Response) AttachmentWithReplies( messagingType MessagingType, metadata string, notificationType NotificationType, - tags ...string, + tags ...TagType, ) (QueryResponse, error) { - var tag string + var tag TagType if len(tags) > 0 { tag = tags[0] } @@ -457,7 +469,7 @@ type SendMessage struct { MessagingType MessagingType `json:"messaging_type"` Recipient Recipient `json:"recipient"` Message MessageData `json:"message"` - Tag string `json:"tag,omitempty"` + Tag TagType `json:"tag,omitempty"` NotificationType NotificationType `json:"notification_type,omitempty"` } From ecaadad6650187362db8192e60445a08c83bc532 Mon Sep 17 00:00:00 2001 From: simus Date: Fri, 30 Dec 2022 16:42:59 +0500 Subject: [PATCH 09/13] bugfix with new types --- messenger.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/messenger.go b/messenger.go index 98d9468..eaf4a64 100644 --- a/messenger.go +++ b/messenger.go @@ -443,7 +443,7 @@ func (m *Messenger) Response(to int64) *Response { } // Send will send a textual message to a user. This user must have previously initiated a conversation with the bot. -func (m *Messenger) Send(to Recipient, message string, messagingType MessagingType, metadata string, tags ...string) (QueryResponse, error) { +func (m *Messenger) Send(to Recipient, message string, messagingType MessagingType, metadata string, tags ...TagType) (QueryResponse, error) { return m.SendWithReplies(to, message, nil, messagingType, metadata, tags...) } @@ -458,14 +458,14 @@ func (m *Messenger) SendGeneralMessage(to Recipient, elements *[]StructuredMessa } // SendWithReplies sends a textual message to a user, but gives them the option of numerous quick response options. -func (m *Messenger) SendWithReplies(to Recipient, message string, replies []QuickReply, messagingType MessagingType, metadata string, tags ...string) (QueryResponse, error) { +func (m *Messenger) SendWithReplies(to Recipient, message string, replies []QuickReply, messagingType MessagingType, metadata string, tags ...TagType) (QueryResponse, error) { response := &Response{ token: m.token, to: to, sendAPIVersion: m.sendAPIVersion, } - return response.TextWithReplies(message, replies, messagingType, metadata, tags...) + return response.TextWithReplies(message, replies, messagingType, metadata, NotificationRegularType, tags...) } // Attachment sends an image, sound, video or a regular file to a given recipient. From 45c2f1aaf52eef7de3a131e6749d450a8ce3881d Mon Sep 17 00:00:00 2001 From: Neur0toxine Date: Fri, 21 Mar 2025 14:20:22 +0300 Subject: [PATCH 10/13] ci & examples fixes --- .github/workflows/ci.yml | 15 +++++++-------- examples/basic/main.go | 3 ++- examples/extension/main.go | 3 ++- examples/linked-account/main.go | 8 +++++--- 4 files changed, 16 insertions(+), 13 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 984137d..01bf744 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,12 +18,11 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code into the Go module directory - uses: actions/checkout@v2 - - name: Set up Go 1.17 - uses: actions/setup-go@v2 + uses: actions/checkout@v4 + - name: Set up Go 1.24 + uses: actions/setup-go@v5 with: - # TODO: Should migrate to 1.18 later - go-version: '1.17' + go-version: '1.24' - name: Get dependencies run: go mod tidy - name: Lint code with golangci-lint @@ -36,14 +35,14 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - go-version: ['1.13', '1.14', '1.15', '1.16', '1.17'] + go-version: ['1.13', '1.14', '1.15', '1.16', '1.17', '1.18', '1.19', '1.20', '1.21', '1.22', '1.23', '1.24'] steps: - name: Set up Go ${{ matrix.go-version }} - uses: actions/setup-go@v2 + uses: actions/setup-go@v5 with: go-version: ${{ matrix.go-version }} - name: Check out code into the Go module directory - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Get dependencies run: go mod tidy - name: Tests diff --git a/examples/basic/main.go b/examples/basic/main.go index 1b12ad9..a33cbeb 100644 --- a/examples/basic/main.go +++ b/examples/basic/main.go @@ -48,7 +48,8 @@ func main() { fmt.Println("Something went wrong!", err) } - r.Text(fmt.Sprintf("Hello, %v!", p.FirstName), messenger.ResponseType, "") + r.Text(fmt.Sprintf("Hello, %v!", p.FirstName), + messenger.ResponseType, "", messenger.NotificationRegularType) }) // Setup a handler to be triggered when a message is delivered diff --git a/examples/extension/main.go b/examples/extension/main.go index 853c0a7..c4034b3 100644 --- a/examples/extension/main.go +++ b/examples/extension/main.go @@ -57,7 +57,8 @@ func main() { fmt.Println("Something went wrong!", err) } - r.Text(fmt.Sprintf("Hello, %v!", p.FirstName), messenger.ResponseType, "") + r.Text(fmt.Sprintf("Hello, %v!", p.FirstName), messenger.ResponseType, + "", messenger.NotificationRegularType) }) addr := fmt.Sprintf("%s:%d", *host, *port) diff --git a/examples/linked-account/main.go b/examples/linked-account/main.go index 67bdc92..557975d 100644 --- a/examples/linked-account/main.go +++ b/examples/linked-account/main.go @@ -84,7 +84,8 @@ func main() { text = "You've been logged out of your account." } - if _, err := r.Text(text, messenger.ResponseType, ""); err != nil { + if _, err := r.Text(text, messenger.ResponseType, + "", messenger.NotificationRegularType); err != nil { log.Println("Failed to send account linking feedback") } }) @@ -134,7 +135,8 @@ func logoutButton(r *messenger.Response) error { // greeting salutes the user. func greeting(p messenger.Profile, r *messenger.Response) error { - _, err := r.Text(fmt.Sprintf("Hello, %v!", p.FirstName), messenger.ResponseType, "") + _, err := r.Text(fmt.Sprintf("Hello, %v!", p.FirstName), messenger.ResponseType, + "", messenger.NotificationRegularType) return err } @@ -156,7 +158,7 @@ func help(p messenger.Profile, r *messenger.Response) error { }, } - _, err := r.TextWithReplies(text, replies, messenger.ResponseType, "") + _, err := r.TextWithReplies(text, replies, messenger.ResponseType, "", messenger.NotificationRegularType) return err } From da336676b770316a058cc87b50e3155d7f83c67a Mon Sep 17 00:00:00 2001 From: Neur0toxine Date: Fri, 21 Mar 2025 14:21:43 +0300 Subject: [PATCH 11/13] update ci & fix examples --- .github/workflows/ci.yml | 2 +- .golangci.yml | 62 ++++++++++++++-------------------------- 2 files changed, 22 insertions(+), 42 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 01bf744..83daba5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,7 +28,7 @@ jobs: - name: Lint code with golangci-lint uses: golangci/golangci-lint-action@v3 with: - version: v1.50.1 + version: v1.62.2 only-new-issues: true tests: name: Tests diff --git a/.golangci.yml b/.golangci.yml index 0a739bc..fa9e330 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -1,31 +1,16 @@ run: skip-dirs-use-default: true allow-parallel-runners: true + modules-download-mode: readonly output: - format: colored-line-number + formats: + - format: colored-line-number sort-results: true -# Linters below do not support go1.18 yet because of generics. -# See https://github.com/golangci/golangci-lint/issues/2649 -# - bodyclose -# - sqlclosecheck - linters: disable-all: true enable: - - paralleltest - - tparallel - - asciicheck - - asasalint - - varnamelen - - reassign - - nilnil - - nilerr - - nakedret - - goprintffuncname - - typecheck - - errchkjson - errcheck - gosimple - govet @@ -33,11 +18,12 @@ linters: - staticcheck - unused - unparam + - bodyclose - dogsled - dupl - errorlint - exhaustive - - exportloopref + - copyloopvar - funlen - gocognit - goconst @@ -46,6 +32,7 @@ linters: - godot - goimports - revive + - mnd - gosec - lll - makezero @@ -53,9 +40,11 @@ linters: - nestif - prealloc - predeclared - - exportloopref + - sqlclosecheck - unconvert - whitespace + - unused + - testifylint linters-settings: govet: @@ -64,11 +53,9 @@ linters-settings: enable: - assign - atomic - - atomicalign - bools - buildtag - copylocks - - fieldalignment - httpresponse - loopclosure - lostcancel @@ -80,6 +67,7 @@ linters-settings: - unmarshal - unreachable - unsafeptr + - unused settings: printf: funcs: @@ -138,20 +126,18 @@ linters-settings: threshold: 200 errorlint: errorf: true - asserts: false - comparison: false exhaustive: check-generated: false default-signifies-exhaustive: false funlen: - lines: 90 - statements: 40 + lines: 65 + statements: 50 gocognit: min-complexity: 25 gocyclo: min-complexity: 25 goimports: - local-prefixes: github.com/retailcrm/messenger + local-prefixes: github.com/retailcrm/mg-transport-api-client-go lll: line-length: 120 misspell: @@ -161,25 +147,23 @@ linters-settings: whitespace: multi-if: false multi-func: false - varnamelen: - max-distance: 10 - ignore-map-index-ok: true - ignore-type-assert-ok: true - ignore-chan-recv-ok: true - ignore-decls: - - t *testing.T - - e error - - i int + issues: exclude-rules: - path: _test\.go linters: + - dupl + - mnd - lll + - bodyclose - errcheck + - sqlclosecheck - misspell - ineffassign - whitespace - makezero + - maligned + - ifshort - errcheck - funlen - goconst @@ -187,10 +171,6 @@ issues: - gocyclo - godot - unused - - errchkjson - - varnamelen - - path: \.go - text: "Error return value of `io.WriteString` is not checked" exclude-use-default: true exclude-case-sensitive: false max-issues-per-linter: 0 @@ -202,4 +182,4 @@ severity: case-sensitive: false service: - golangci-lint-version: 1.50.x + golangci-lint-version: 1.62.x \ No newline at end of file From 171f0a0d67dd0fbe75923ca929b2288698b84c76 Mon Sep 17 00:00:00 2001 From: Neur0toxine Date: Fri, 21 Mar 2025 14:22:28 +0300 Subject: [PATCH 12/13] update lint rules --- .golangci.yml | 1 - messenger.go | 2 +- profile.go | 2 +- response.go | 18 +++++++++--------- 4 files changed, 11 insertions(+), 12 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index fa9e330..99585ab 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -34,7 +34,6 @@ linters: - revive - mnd - gosec - - lll - makezero - misspell - nestif diff --git a/messenger.go b/messenger.go index eaf4a64..fa860f5 100644 --- a/messenger.go +++ b/messenger.go @@ -304,7 +304,7 @@ func (m *Messenger) handle(w http.ResponseWriter, r *http.Request) { } if rec.Object != "page" && rec.Object != "instagram" { - fmt.Println("Object is not page or instagram, undefined behaviour. Got", rec.Object) + fmt.Println("Object is not page or instagram, undefined behavior. Got", rec.Object) respond(w, http.StatusUnprocessableEntity) return } diff --git a/profile.go b/profile.go index d5ae231..188565d 100644 --- a/profile.go +++ b/profile.go @@ -13,7 +13,7 @@ type Profile struct { // instagram user profile Username string `json:"username,omitempty"` IsPrivate bool `json:"is_private,omitempty"` - //FollowCount int32 `json:"follow_count,omitempty"` + // FollowCount int32 `json:"follow_count,omitempty"` FollowedByCount int32 `json:"follower_count,omitempty"` // by the documentation followed_by_count IsVerifiedUser bool `json:"is_verified_user"` IsUserFollowBusiness bool `json:"is_user_follow_business"` diff --git a/response.go b/response.go index 9393e23..47479b0 100644 --- a/response.go +++ b/response.go @@ -52,11 +52,11 @@ const ( // NonPromotionalSubscriptionType is NON_PROMOTIONAL_SUBSCRIPTION messaging type. NonPromotionalSubscriptionType MessagingType = "NON_PROMOTIONAL_SUBSCRIPTION" - // NotificationNoPushType is NO_PUSH notification type. No notification + // NotificationNoPushType is NO_PUSH notification type. No notification. NotificationNoPushType NotificationType = "NO_PUSH" - // NotificationRegularType is REGULAR notification type (default). Sound or vibration when a message is received by a person + // NotificationRegularType is REGULAR notification type (default). Sound or vibration when a message is received by a person. NotificationRegularType NotificationType = "REGULAR" - // NotificationSilentPushType is SILENT_PUSH notification type. On-screen notification only + // NotificationSilentPushType is SILENT_PUSH notification type. On-screen notification only. NotificationSilentPushType NotificationType = "SILENT_PUSH" // TopElementStyle is compact. @@ -73,13 +73,13 @@ const ( SenderActionTypingOn SenderAction = "typing_on" SenderActionTypingOff SenderAction = "typing_off" - // TagAccountUpdateType Tags the message you are sending to your customer as a non-recurring update to their application or account. Not available for Instagram Messaging API + // TagAccountUpdateType Tags the message you are sending to your customer as a non-recurring update to their application or account. Not available for Instagram Messaging API. TagAccountUpdateType TagType = "ACCOUNT_UPDATE" - // TagConfirmedEventUpdateType Tags the message you are sending to your customer as a reminder fo an upcoming event or an update for an event in procgres for which the customer is registered. Not available for Instagram Messaging API + // TagConfirmedEventUpdateType Tags the message you are sending to your customer as a reminder fo an upcoming event or an update for an event in procgres for which the customer is registered. Not available for Instagram Messaging API. TagConfirmedEventUpdateType TagType = "CONFIRMED_EVENT_UPDATE" - // TagCustomerFeedbackType Tags the message you are sending to your customer as a Customer Feedback Survey. Customer feedback messages must be sent within 7 days of the customer's last message. Not available for Instagram Messaging API + // TagCustomerFeedbackType Tags the message you are sending to your customer as a Customer Feedback Survey. Customer feedback messages must be sent within 7 days of the customer's last message. Not available for Instagram Messaging API. TagCustomerFeedbackType TagType = "CUSTOMER_FEEDBACK" - // TagHumanAgentType When this tag is added to a message to a customer, it allows a human agent to respond to a person's message. Messages can be sent within 7 days of the person's. Human agent support is for issues that cannot be resolved within the standard 24 hour messaging window + // TagHumanAgentType When this tag is added to a message to a customer, it allows a human agent to respond to a person's message. Messages can be sent within 7 days of the person's. Human agent support is for issues that cannot be resolved within the standard 24 hour messaging window. TagHumanAgentType TagType = "HUMAN_AGENT" // TagPostPurchaseUpdateType Tags the message you are sending to your customer as an update for a recent purchase made by the customer. Not available for Instagram Messaging API. TagPostPurchaseUpdateType TagType = "POST_PURCHASE_UPDATE" @@ -162,7 +162,7 @@ func (r *Response) Text( // only supply tags when messagingType == "MESSAGE_TAG" // (see https://developers.facebook.com/docs/messenger-platform/send-messages#messaging_types for more). // notificationType should be one of the following: "NO_PUSH","REGULAR" (default),"SILENT_PUSH" -// only supply tags when messagingType == "MESSAGE_TAG" (see https://developers.facebook.com/docs/messenger-platform/send-messages#messaging_types for more) +// only supply tags when messagingType == "MESSAGE_TAG" (see https://developers.facebook.com/docs/messenger-platform/send-messages#messaging_types for more). func (r *Response) TextWithReplies( message string, replies []QuickReply, @@ -191,7 +191,7 @@ func (r *Response) TextWithReplies( return r.DispatchMessage(&m) } -// AttachmentWithReplies sends a attachment message with some replies +// AttachmentWithReplies sends a attachment message with some replies. func (r *Response) AttachmentWithReplies( attachment *StructuredMessageAttachment, replies []QuickReply, From e00f1b68879cbf485b63aa67b495fac56c125b2c Mon Sep 17 00:00:00 2001 From: Neur0toxine Date: Fri, 21 Mar 2025 14:24:45 +0300 Subject: [PATCH 13/13] remove Go versions older than 1.16 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 83daba5..605fafd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -35,7 +35,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - go-version: ['1.13', '1.14', '1.15', '1.16', '1.17', '1.18', '1.19', '1.20', '1.21', '1.22', '1.23', '1.24'] + go-version: ['1.16', '1.17', '1.18', '1.19', '1.20', '1.21', '1.22', '1.23', '1.24'] steps: - name: Set up Go ${{ matrix.go-version }} uses: actions/setup-go@v5