.docker/Dockerfile

@@ -2,7 +2,7 @@ FROM php:7.1-apache
 
 RUN apt-get update
 
-RUN apt-get install -y netcat zlib1g-dev libpq-dev git libicu-dev libxml2-dev libpng-dev libjpeg-dev libmcrypt-dev libxslt-dev libfreetype6-dev unzip \
+RUN apt-get install -y netcat zlib1g-dev libpq-dev git libicu-dev libxml2-dev libpng-dev libjpeg-dev libmcrypt-dev libxslt-dev libfreetype6-dev \
     && docker-php-ext-configure intl \
     && docker-php-ext-install intl \
     && docker-php-ext-configure pgsql -with-pgsql=/usr/local/pgsql \

.github/workflows/ci.yml

@@ -26,6 +26,15 @@ jobs:
     strategy:
       matrix:
         include:
+          - php-version: '7.3'
+            test-suite: '3'
+            oc: '3.0.0.0'
+          - php-version: '7.3'
+            test-suite: '3'
+            oc: '3.0.0.2'
+          - php-version: '7.3'
+            test-suite: '3'
+            oc: '3.0.1.0'
           - php-version: '7.3'
             test-suite: '3'
             oc: '3.0.1.1'
@@ -62,6 +71,15 @@ jobs:
           - php-version: '7.3'
             test-suite: '3'
             oc: '3.0.3.8'
+          - php-version: '7.4'
+            test-suite: '3'
+            oc: '3.0.0.0'
+          - php-version: '7.4'
+            test-suite: '3'
+            oc: '3.0.0.2'
+          - php-version: '7.4'
+            test-suite: '3'
+            oc: '3.0.1.0'
           - php-version: '7.4'
             test-suite: '3'
             oc: '3.0.1.1'

CHANGELOG.md

@@ -1,39 +1,3 @@
-## v4.1.19
-* Added option to round order amount
-
-## v4.1.18
-* Fixed constant with version of module.
-
-## v4.1.17
-* Added additional parameters to GET requests.
-
-## v4.1.16
-* Support for services in ICML
-
-## v4.1.15
-* Display module version
-
-## v4.1.14
-* Added currency validation when configuring the module
-
-## v4.1.13
-* Changed the logic of customer subscriptions to promotional newsletters
-
-## v4.1.12
-* Added escaping for db query in method for getting zone
-
-## v4.1.11
-* Fixed the transfer of the weight offers
-
-## v4.1.10
-* Types of deliveries and payments are displayed only active status and available stores
-
-## v4.1.9
-* Optimization of the history processing algorithm
-
-## v4.1.8
-* Fixed customer externalId when creating a customer and sending it to RetailCRM
-
 ## v4.1.7
 * Fixed notices in ICML generation and while setting delivery type
 * Fixed incorrect data check before setting payment data

VERSION

@@ -1 +1 @@
-4.1.19
+4.1.7

doc/Update module.md

@@ -1,6 +0,0 @@
-### Обновление версии модуля
-
-Для обновления версии модуля необходимо обновить следующие файлы:
-* VERSION
-* CHANGELOG.md
-* src/upload/admin/controller/extension/module/retailcrm.php

src/upload/admin/controller/extension/module/retailcrm.php

@@ -1,10 +1,8 @@
 <?php
 
-use retailcrm\Retailcrm;
-
 class ControllerExtensionModuleRetailcrm extends Controller
 {
-    private $_error = [];
+    private $_error = array();
     protected $log, $statuses, $payments, $deliveryTypes, $retailcrmApiClient, $moduleTitle, $tokenTitle;
     public $children, $template;
 
@@ -27,10 +25,10 @@ class ControllerExtensionModuleRetailcrm extends Controller
 
         $this->model_setting_setting->editSetting(
             $this->moduleTitle,
-            [
+            array(
                 $this->moduleTitle . '_status' => 1,
-                $this->moduleTitle . '_country' => [$this->config->get('config_country_id')]
+                $this->moduleTitle . '_country' => array($this->config->get('config_country_id'))
-            ]
+            )
         );
 
         $this->addEvents();
@@ -61,7 +59,7 @@ class ControllerExtensionModuleRetailcrm extends Controller
             $this->uninstall_collector();
             $this->model_setting_setting->editSetting(
                 $this->moduleTitle,
-                [$this->moduleTitle . '_status' => 0]
+                array($this->moduleTitle . '_status' => 0)
             );
         }
 
@@ -81,7 +79,7 @@ class ControllerExtensionModuleRetailcrm extends Controller
         $this->loadModels();
         $this->load->model('setting/setting');
         $this->{'model_' . $this->modelExtension}->install('analytics', 'daemon_collector');
-        $this->model_setting_setting->editSetting($collector, [$collector . '_status' => 1]);
+        $this->model_setting_setting->editSetting($collector, array($collector . '_status' => 1));
     }
 
     /**
@@ -94,7 +92,7 @@ class ControllerExtensionModuleRetailcrm extends Controller
         $collector = $this->getCollectorTitle();
         $this->loadModels();
         $this->load->model('setting/setting');
-        $this->model_setting_setting->editSetting($collector, [$collector . '_status' => 0]);
+        $this->model_setting_setting->editSetting($collector, array($collector . '_status' => 0));
         $this->{'model_' . $this->modelExtension}->uninstall('analytics', 'daemon_collector');
     }
 
@@ -109,7 +107,7 @@ class ControllerExtensionModuleRetailcrm extends Controller
         $this->loadModels();
         $this->load->model('setting/setting');
         $this->{'model_' . $this->modelExtension}->install('analytics', 'online_consultant');
-        $this->model_setting_setting->editSetting($consultant, [$consultant . '_status' => 1]);
+        $this->model_setting_setting->editSetting($consultant, array($consultant . '_status' => 1));
     }
 
     /**
@@ -122,7 +120,7 @@ class ControllerExtensionModuleRetailcrm extends Controller
         $consultant = $this->getConsultantTitle();
         $this->loadModels();
         $this->load->model('setting/setting');
-        $this->model_setting_setting->editSetting($consultant, [$consultant . '_status' => 0]);
+        $this->model_setting_setting->editSetting($consultant, array($consultant . '_status' => 0));
         $this->{'model_' . $this->modelExtension}->uninstall('analytics', 'online_consultant');
     }
 
@@ -188,21 +186,42 @@ class ControllerExtensionModuleRetailcrm extends Controller
                 $this->request->post
             );
 
-            if (
+            if (!isset($history_setting['retailcrm_history_orders']) && !isset($history_setting['retailcrm_history_customers'])) {
-                !isset($history_setting['retailcrm_history_orders'])
-                && !isset($history_setting['retailcrm_history_customers'])
-            ) {
                 $api = $this->retailcrm->getApiClient(
                     $this->request->post[$this->moduleTitle . '_url'],
                     $this->request->post[$this->moduleTitle . '_apikey']
                 );
 
+                $ordersHistory = $api->ordersHistory();
+
+                if ($ordersHistory && $ordersHistory->isSuccessful() && !empty($ordersHistory['history'])) {
+                    $ordersHistory = $api->ordersHistory(array(), $ordersHistory['pagination']['totalPageCount']);
+
+                    if ($ordersHistory && $ordersHistory->isSuccessful()) {
+                        $ordersHistoryArr = $ordersHistory['history'];
+                        $lastChangeOrders = end($ordersHistoryArr);
+                        $sinceIdOrders = $lastChangeOrders['id'];
+                    }
+                }
+
+                $customersHistory = $api->customersHistory();
+
+                if ($customersHistory && $customersHistory->isSuccessful() && !empty($customersHistory['history'])) {
+                    $customersHistory = $api->customersHistory(array(), $customersHistory['pagination']['totalPageCount']);
+
+                    if ($customersHistory && $customersHistory->isSuccessful()) {
+                        $customersHistoryArr = $customersHistory['history'];
+                        $lastChangeCustomers = end($customersHistoryArr);
+                        $sinceIdCustomers = $lastChangeCustomers['id'];
+                    }
+                }
+
                 $this->model_setting_setting->editSetting(
                     'retailcrm_history',
-                    [
+                    array(
-                        'retailcrm_history_orders' => $this->getHistorySinceId($api, 'ordersHistory'),
+                        'retailcrm_history_orders' => isset($sinceIdOrders) ? $sinceIdOrders : 1,
-                        'retailcrm_history_customers' => $this->getHistorySinceId($api, 'customersHistory'),
+                        'retailcrm_history_customers' => isset($sinceIdCustomers) ? $sinceIdCustomers : 1
-                    ]
+                    )
                 );
             }
 
@@ -223,12 +242,12 @@ class ControllerExtensionModuleRetailcrm extends Controller
                 if ($result === true) {
                     $this->model_setting_setting->editSetting(
                         'retailcrm_setting',
-                        [
+                        array(
                             'retailcrm_setting_active_in_crm' => true,
                             'retailcrm_setting_client_id' => $clientId,
                             'retailcrm_setting_url' => $this->request->post[$this->moduleTitle . '_url'],
                             'retailcrm_setting_key' => $this->request->post[$this->moduleTitle . '_apikey']
-                        ]
+                        )
                     );
                 }
             }
@@ -242,7 +261,7 @@ class ControllerExtensionModuleRetailcrm extends Controller
             $this->response->redirect($redirect);
         }
 
-        $text_strings = [
+        $text_strings = array(
             'heading_title',
             'text_enabled',
             'text_disabled',
@@ -301,11 +320,7 @@ class ControllerExtensionModuleRetailcrm extends Controller
             'special_price',
             'order_number',
             'text_order_number',
-            'summ_around',
+            'text_currency',
-            'text_summ_around',
-            'icml_settings',
-            'icml_service_enabled_label',
-            'icml_service_description',
             'text_currency_label',
             'status_changes',
             'text_status_changes',
@@ -318,39 +333,35 @@ class ControllerExtensionModuleRetailcrm extends Controller
             'text_retailcrm_label_discount',
             'default_retailcrm_label_discount',
             'sum_payment',
-            'text_sum_payment',
+            'text_sum_payment'
-        ];
+        );
 
         $_data = &$data;
 
-        $_data['module_version'] = Retailcrm::VERSION_MODULE;
-
         foreach ($text_strings as $text) {
             $_data[$text] = $this->language->get($text);
         }
 
         $_data['currencies'] = $this->model_localisation_currency->getCurrencies(0);
-        $_data['retailcrm_errors'] = [];
+        $_data['retailcrm_errors'] = array();
         $_data['saved_settings'] = $this->model_setting_setting
             ->getSetting($this->moduleTitle);
 
-        $url = $_data['saved_settings'][$this->moduleTitle . '_url'] ?? null;
+        $url = isset($_data['saved_settings'][$this->moduleTitle . '_url'])
-        $key = $_data['saved_settings'][$this->moduleTitle . '_apikey'] ?? null;
+            ? $_data['saved_settings'][$this->moduleTitle . '_url']
+            : null;
+        $key = isset($_data['saved_settings'][$this->moduleTitle . '_apikey'])
+            ? $_data['saved_settings'][$this->moduleTitle . '_apikey']
+            : null;
 
         if (!empty($url) && !empty($key)) {
-            $this->validate($url, $key);
 
-            $site = $this->model_extension_retailcrm_references->getApiSite();
+            $_data['delivery'] = $this->model_extension_retailcrm_references
-            $_data['delivery'] = $this->getAvailableTypes(
+                ->getDeliveryTypes();
-                $site,
-                $this->model_extension_retailcrm_references->getDeliveryTypes()
-            );
-            $_data['payments'] = $this->getAvailableTypes(
-                $site,
-                $this->model_extension_retailcrm_references->getPaymentTypes()
-            );
             $_data['statuses'] = $this->model_extension_retailcrm_references
                 ->getOrderStatuses();
+            $_data['payments'] = $this->model_extension_retailcrm_references
+                ->getPaymentTypes();
             $_data['customFields'] = $this->model_extension_retailcrm_references
                 ->getCustomFields();
 
@@ -360,7 +371,9 @@ class ControllerExtensionModuleRetailcrm extends Controller
             $_data['customerGroups'] = $this->model_customer_customer_group->getCustomerGroups();
         }
 
-        $config_data = [$this->moduleTitle . '_status'];
+        $config_data = array(
+            $this->moduleTitle . '_status'
+        );
 
         foreach ($config_data as $conf) {
             if (isset($this->request->post[$conf])) {
@@ -370,35 +383,40 @@ class ControllerExtensionModuleRetailcrm extends Controller
             }
         }
 
-        $_data['error_warning'] = $this->_error['warning'] ?? '';
+        if (isset($this->_error['warning'])) {
-        $_data['breadcrumbs'] = [];
+            $_data['error_warning'] = $this->_error['warning'];
+        } else {
+            $_data['error_warning'] = '';
+        }
 
-        $_data['breadcrumbs'][] = [
+        $_data['breadcrumbs'] = array();
+
+        $_data['breadcrumbs'][] = array(
             'text'      => $this->language->get('text_home'),
             'href'      => $this->url->link(
                 'common/dashboard',
                 $this->tokenTitle . '=' . $this->session->data[$this->tokenTitle], 'SSL'
             ),
             'separator' => false
-        ];
+        );
 
-        $_data['breadcrumbs'][] = [
+        $_data['breadcrumbs'][] = array(
             'text'      => $this->language->get('text_module'),
             'href'      => $this->url->link(
                 'extension/extension',
                 $this->tokenTitle . '=' . $this->session->data[$this->tokenTitle], 'SSL'
             ),
             'separator' => ' :: '
-        ];
+        );
 
-        $_data['breadcrumbs'][] = [
+        $_data['breadcrumbs'][] = array(
             'text'      => $this->language->get('retailcrm_title'),
             'href'      => $this->url->link(
                 'extension/module/retailcrm',
                 $this->tokenTitle . '=' . $this->session->data[$this->tokenTitle], 'SSL'
             ),
             'separator' => ' :: '
-        ];
+        );
 
         $_data['action'] = $this->url->link(
             'extension/module/retailcrm',
@@ -410,7 +428,7 @@ class ControllerExtensionModuleRetailcrm extends Controller
             $this->tokenTitle . '=' . $this->session->data[$this->tokenTitle], 'SSL'
         );
 
-        $_data['modules'] = [];
+        $_data['modules'] = array();
 
         if (isset($this->request->post['retailcrm_module'])) {
             $_data['modules'] = $this->request->post['retailcrm_module'];
@@ -434,11 +452,11 @@ class ControllerExtensionModuleRetailcrm extends Controller
             $_data['export_file'] = true;
         }
 
-        $collectorFields = [
+        $collectorFields = array(
             'name' => $this->language->get('field_name'),
             'email' => $this->language->get('field_email'),
             'phone' => $this->language->get('field_phone')
-        ];
+        );
 
         $_data['collectorFields'] = $collectorFields;
 
@@ -557,12 +575,20 @@ class ControllerExtensionModuleRetailcrm extends Controller
 
                     $this->response->setOutput(
                         json_encode(
-                            ['status_code' => $response->getStatusCode(), 'error_msg' => $error],
+                            array(
-                            JSON_THROW_ON_ERROR
+                                'status_code' => $response->getStatusCode(),
+                                'error_msg' => $error
+                            )
                         )
                     );
                 } else {
-                    $this->response->setOutput(json_encode(['status_code' => $response->getStatusCode()]));
+                    $this->response->setOutput(
+                        json_encode(
+                            array(
+                                'status_code' => $response->getStatusCode()
+                            )
+                        )
+                    );
                 }
             }
         }
@@ -582,7 +608,7 @@ class ControllerExtensionModuleRetailcrm extends Controller
         $this->model_extension_retailcrm_customer->uploadToCrm($customers, $this->retailcrm->getApiClient());
         $orders = $this->model_sale_order->getOrders();
 
-        $fullOrders = [];
+        $fullOrders = array();
 
         foreach ($orders as $order) {
             $fullOrder = $this->model_sale_order->getOrder($order['order_id']);
@@ -625,57 +651,39 @@ class ControllerExtensionModuleRetailcrm extends Controller
      *
      * @return bool
      */
-    private function validate($apiUrl = null, $apiKey = null)
+    private function validate()
     {
-        $warningMessage = '';
+        if (!empty($this->request->post[$this->moduleTitle . '_url']) && !empty($this->request->post[$this->moduleTitle . '_apikey'])) {
-
+            $apiClient = $this->retailcrm->getApiClient(
-        $apiUrl = $this->request->post[$this->moduleTitle . '_url'] ?? $apiUrl;
+                $this->request->post[$this->moduleTitle . '_url'],
-        $apiKey = $this->request->post[$this->moduleTitle . '_apikey'] ?? $apiKey;
+                $this->request->post[$this->moduleTitle . '_apikey']
-
-        try {
-            if ( !empty($apiUrl) && !empty($apiKey)) {
-                $apiClient = $this->retailcrm->getApiClient($apiUrl, $apiKey);
-                $response = $apiClient->sitesList();
-
-                if (empty($response['sites']) || !$response->isSuccessful()) {
-                    $warningMessage = 'text_error_api_key';
-                } elseif (count($response['sites']) > 1)  {
-                    $warningMessage = 'text_error_api_key_site';
-                } else {
-                    $site = current($response['sites']);
-
-                    if ($this->config->get('config_currency') !== $site['currency']) {
-                        $warningMessage = 'text_error_api_key_currency';
-                    }
-                }
-
-                if (!$this->user->hasPermission('modify', 'extension/module/retailcrm')) {
-                    $this->_error['warning'] = $this->language->get('error_permission');
-                }
-
-                if (isset($this->request->post[$this->moduleTitle . '_collector']['custom']) &&
-                    $this->request->post[$this->moduleTitle . '_collector']['custom_form'] == 1) {
-                    $customField = $this->request->post[$this->moduleTitle . '_collector']['custom'];
-
-                    if (empty($customField['name']) && empty($customField['email']) && empty($customField['phone'])) {
-                        $this->_error['fields'] = $this->language->get('text_error_collector_fields');
-                    }
-                }
-            } else {
-                $warningMessage = 'text_error_api_empty';
-            }
-        } catch (Throwable $exception) {
-            $warningMessage = sprintf(
-                'An error has occurred! In file: %s, on line: %s. Error message: %s',
-                $exception->getFile(), $exception->getLine(), $exception->getMessage()
             );
         }
 
-        if ('' !== $warningMessage) {
+        $response = $apiClient->apiVersions();
-            $this->_error['warning'] = $this->language->get($warningMessage);
+
+        if (!$response || !$response->isSuccessful()) {
+            $this->_error['warning'] = $this->language->get('text_error_api');
         }
 
-        return empty($this->_error);
+        if (!$this->user->hasPermission('modify', 'extension/module/retailcrm')) {
+            $this->_error['warning'] = $this->language->get('error_permission');
+        }
+
+        if (isset($this->request->post[$this->moduleTitle . '_collector']['custom']) &&
+            $this->request->post[$this->moduleTitle . '_collector']['custom_form'] == 1) {
+            $customField = $this->request->post[$this->moduleTitle . '_collector']['custom'];
+
+            if (empty($customField['name']) && empty($customField['email']) && empty($customField['phone'])) {
+                $this->_error['fields'] = $this->language->get('text_error_collector_fields');
+            }
+        }
+
+        if (!$this->_error) {
+            return true;
+        } else {
+            return false;
+        }
     }
 
     /**
@@ -831,13 +839,6 @@ class ControllerExtensionModuleRetailcrm extends Controller
                 'extension/module/retailcrm/customer_edit'
             );
 
-        $this->{'model_' . $this->modelEvent}
-            ->addEvent(
-                $this->moduleTitle,
-                'catalog/model/account/customer/editNewsletter/after',
-                'extension/module/retailcrm/customer_edit_newsletter'
-            );
-
         $this->{'model_' . $this->modelEvent}
             ->addEvent(
                 $this->moduleTitle,
@@ -911,15 +912,15 @@ class ControllerExtensionModuleRetailcrm extends Controller
         $name = 'Opencart';
         $accountUrl = $scheme . $this->request->server['HTTP_HOST'] . '/admin';
 
-        $configuration = [
+        $configuration = array(
             'clientId' => $clientId,
             'code' => $integrationCode . '-' . $clientId,
             'integrationCode' => $integrationCode,
             'active' => $active,
             'name' => $name,
             'logo' => $logo,
-            'accountUrl' => $accountUrl,
+            'accountUrl' => $accountUrl
-        ];
+        );
 
         $response = $apiClient->integrationModulesEdit($configuration);
 
@@ -933,57 +934,4 @@ class ControllerExtensionModuleRetailcrm extends Controller
 
         return false;
     }
-
-    private function getHistorySinceId($api, $method)
-    {
-        $lastSinceId = 0;
-        $startDate = new DateTime('-1 days');
-        $historyResponse = $api->$method(['startDate' => $startDate->format('Y-m-d H:i:s')]);
-
-        if (
-            !$historyResponse instanceof ApiResponse
-            || !$historyResponse->isSuccessful()
-            || empty($historyResponse['history'])
-            || empty($historyResponse['pagination'])
-        ) {
-            return $lastSinceId;
-        }
-
-        $startPage = $historyResponse['pagination']['currentPage'];
-        $lastPage = $historyResponse['pagination']['totalPageCount'];
-
-        for ($startPage; $startPage <= $lastPage; ++$startPage) {
-            if ($historyResponse instanceof ApiResponse && !empty($historyResponse['history'])) {
-                $history = $historyResponse['history'];
-                $lastSinceId = end($history)['id'];
-                $historyResponse = $api->$method(['sinceId' => $lastSinceId]);
-            }
-        }
-
-        return $lastSinceId;
-    }
-
-    private function getAvailableTypes($availableSite, $types)
-    {
-        $result['opencart'] = $types['opencart'];
-        $result['retailcrm'] = [];
-
-        if (empty($availableSite)) {
-            return $result;
-        }
-
-        foreach ($types['retailcrm'] as $codeKey => $type) {
-            if ($type['active'] !== true) {
-                continue;
-            }
-
-            if (!empty($type['sites']) && !in_array($availableSite['code'], $type['sites'])) {
-                continue;
-            }
-
-            $result['retailcrm'][$codeKey] = $type;
-        }
-
-        return $result;
-    }
 }

src/upload/admin/language/en-gb/extension/module/retailcrm.php

@@ -50,11 +50,8 @@ $_['text_payment']               = 'Payment';
 $_['text_shipping']              = 'Delivery';
 $_['text_orders_custom_fields']  = 'Custom fields of orders';
 $_['text_customers_custom_fields'] = 'Custom fields of customers';
-$_['text_error_collector_fields'] = 'Fill in the names of fields of Demon Collector form';
+$_['text_error_collector_fields']= 'Fill in the names of fields of Demon Collector form';
-$_['text_error_api_empty']        = 'The "RetailCRM URL" and "RetailCRM API key" fields cannot be empty, enter the correct value';
+$_['text_error_api']             = 'The selected API version is not available.';
-$_['text_error_api_key']         = 'Invalid API key';
-$_['text_error_api_key_site']    = 'API key with one-shop access required';
-$_['text_error_api_key_currency'] = 'The currency of the site differs from the currency of the store in CRM. For the integration to work correctly, the currencies in CRM and CMS must match';
 $_['text_error_custom_field']    = 'Create custom fields on a customer page in Opencart and RetailCRM in order to set up their transfer';
 $_['text_error_cf_opencart']     = 'There are no custom fields in Opencart';
 $_['text_error_cf_retailcrm']    = 'There are no custom fields in RetailCRM';
@@ -72,14 +69,10 @@ $_['retailcrm_missing_status']   = 'Status of lost orders';
 
 $_['order_number']               = 'Order number';
 $_['text_order_number']          = 'Upload the order number to RetailCRM';
-$_['summ_around']               = 'Around total summ';
+$_['text_currency']              = 'Currency setting';
-$_['text_summ_around']          = 'Around the order total summ';
+$_['text_currency_label']        = 'Currency in ICML';
-$_['icml_settings']              = 'ICML settings';
-$_['icml_service_enabled_label'] = 'Upload services in ICML';
-$_['icml_service_description']   = 'When the option is enabled, all products for which delivery is disabled will be considered as services and uploaded to CRM as services';
-$_['text_currency_label']        = 'Currency of goods';
 $_['text_lenght']                = 'Setting of the unit of measurement';
-$_['text_lenght_label']          = 'Unit of measurement of goods';
+$_['text_lenght_label']          = 'Unit of measurement in ICML';
 $_['status_changes']             = 'History of changes';
 $_['text_status_changes']        = 'Record changes to the order history of Opencart';
 

src/upload/admin/language/es-es/extension/module/retailcrm.php

@@ -51,10 +51,7 @@ $_['text_shipping']              = 'Envío';
 $_['text_orders_custom_fields']  = 'Los campos de pedidos personalizados';
 $_['text_customers_custom_fields'] = 'Los campos de clientes personalizados';
 $_['text_error_collector_fields']= 'Rellene los nombres de los campos del formulario Daemon Collector';
-$_['text_error_api_empty']        = 'Los campos "URL de RetailCRM" y "Clave de API de RetailCRM" no pueden estar vacíos, ingrese el valor correcto';
+$_['text_error_api']             = 'La versión seleccionada de la API no está disponible.';
-$_['text_error_api_key']         = 'Clave API del CRM no válida';
-$_['text_error_api_key_site']    = 'Se requiere clave API con acceso a una tienda';
-$_['text_error_api_key_currency'] = 'La moneda del sitio web es distinto a la tienda del CRM. Para el funcionamiento correcto de la integración, las monedas del CMS y CRM deben coincid';
 $_['text_error_custom_field']    = 'Cree campos personalizados en la ficha del cliente en Opencart y RetailCRM para configurar sus transmisión.';
 $_['text_error_cf_opencart']     = 'Faltan campos personalizados en Opencart';
 $_['text_error_cf_retailcrm']    = 'Faltan campos personalizados en RetailCRM';
@@ -72,15 +69,10 @@ $_['retailcrm_missing_status']   = 'Estado de pedidos perdidos';
 
 $_['order_number']               = 'Número de pedido';
 $_['text_order_number']          = 'Transferir número de pedido a RetailCRM';
-$_['summ_around']               = 'Redondeo del costo del pedido';
+$_['text_currency']              = 'Ajustes de moneda';
-$_['text_summ_around']          = 'Redondear los costos del pedido a RetailCRM';
+$_['text_currency_label']        = 'Moneda en ICML';
-$_['icml_settings']              = 'Ajustes de ICML';
-$_['icml_service_enabled_label'] = 'Subir servicios de ICML';
-$_['icml_service_description']   = 'Si habilita la opción, todos los productos para los que la entrega está desactivada se tratarán como servicios y se cargarán en CRM como servicios';
-
-$_['text_currency_label']        = 'Moneda de bienes';
 $_['text_lenght']                = 'Ajustar unidad de medida';
-$_['text_lenght_label']          = 'Unidad de medida de bienes';
+$_['text_lenght_label']          = 'Unidad de medida en ICML';
 $_['status_changes']             = 'Historial de cambios';
 $_['text_status_changes']        = 'Registrar los cambios en el historial de pedidos de Opencart';
 

src/upload/admin/language/ru-ru/extension/module/retailcrm.php

@@ -50,11 +50,8 @@ $_['text_payment']               = 'Оплата';
 $_['text_shipping']              = 'Доставка';
 $_['text_orders_custom_fields']  = 'Кастомные поля заказов';
 $_['text_customers_custom_fields'] = 'Кастомные поля клиентов';
-$_['text_error_collector_fields'] = 'Заполните названия полей формы Демон Collector';
+$_['text_error_collector_fields']= 'Заполните названия полей формы Демон Collector';
-$_['text_error_api_empty']        = 'Поля "URL RetailCRM" и "Ключ API RetailCRM" не могут быть пустыми, введите корректное значение';
+$_['text_error_api']             = 'Недоступна выбранная версия API.';
-$_['text_error_api_key']         = 'Неверный API ключ';
-$_['text_error_api_key_site']    = 'Требуется API ключ с доступом к одному магазину';
-$_['text_error_api_key_currency'] = 'Валюта сайта отличается от валюты магазина в CRM. Для корректной работы интеграции, валюты в CRM и CMS должны совпадать';
 $_['text_error_custom_field']    = 'Создайте пользовательские поля в карточке клиента в Opencart и RetailCRM, чтобы настроить их передачу';
 $_['text_error_cf_opencart']     = 'Отсутствуют пользовательские поля в Opencart';
 $_['text_error_cf_retailcrm']    = 'Отсутствуют пользовательские поля в RetailCRM';
@@ -72,14 +69,10 @@ $_['retailcrm_missing_status']   = 'Статус пропавших заказо
 
 $_['order_number']               = 'Номер заказа';
 $_['text_order_number']          = 'Передавать номер заказа в RetailCRM';
-$_['summ_around']               = 'Округление суммы заказа';
+$_['text_currency']              = 'Настройка валюты';
-$_['text_summ_around']          = 'Округлять сумму заказа';
+$_['text_currency_label']        = 'Валюта в ICML';
-$_['icml_settings']              = 'Настройки ICML';
-$_['icml_service_enabled_label'] = 'Выгружать услуги в ICML';
-$_['icml_service_description']   = 'При включении опции все товары, для которых отключена доставка, будут рассматриваться как услуги и загружаться в CRM как услуги';
-$_['text_currency_label']        = 'Валюта товаров';
 $_['text_lenght']                = 'Настройка единицы измерения';
-$_['text_lenght_label']          = 'Единица измерения товаров';
+$_['text_lenght_label']          = 'Единица измерения в ICML';
 $_['status_changes']             = 'История изменений';
 $_['text_status_changes']        = 'Фиксировать изменения в истории заказа Opencart';
 

src/upload/admin/model/extension/retailcrm/history.php

@@ -72,10 +72,15 @@ class ModelExtensionRetailcrmHistory extends Model {
             return false;
         }
 
-        $sinceIdOrders = $history['retailcrm_history_orders'] ?? 0;
+        $sinceIdOrders = $history['retailcrm_history_orders'] ? $history['retailcrm_history_orders'] : null;
-        $sinceIdCustomers = $history['retailcrm_history_customers'] ?? 0;
+        $sinceIdCustomers = $history['retailcrm_history_customers'] ? $history['retailcrm_history_customers'] : null;
-        $packsOrders = $retailcrmApiClient->ordersHistory(['sinceId' => $sinceIdOrders]);
+
-        $packsCustomers = $retailcrmApiClient->customersHistory(['sinceId' => $sinceIdCustomers]);
+        $packsOrders = $retailcrmApiClient->ordersHistory(array(
+            'sinceId' => $sinceIdOrders ? $sinceIdOrders : 0
+        ), 1, 100);
+        $packsCustomers = $retailcrmApiClient->customersHistory(array(
+            'sinceId' => $sinceIdCustomers ? $sinceIdCustomers : 0
+        ), 1, 100);
 
         if (!$packsOrders->isSuccessful() && count($packsOrders->history) <= 0
             && !$packsCustomers->isSuccessful() && count($packsCustomers->history) <= 0
@@ -83,28 +88,30 @@ class ModelExtensionRetailcrmHistory extends Model {
             return false;
         }
 
+        $orders = RetailcrmHistoryHelper::assemblyOrder($packsOrders->history);
+        $customers = RetailcrmHistoryHelper::assemblyCustomer($packsCustomers->history);
+
         $ordersHistory = $packsOrders->history;
         $customersHistory = $packsCustomers->history;
+
         $lastChangeOrders = $ordersHistory ? end($ordersHistory) : null;
         $lastChangeCustomers = $customersHistory ? end($customersHistory) : null;
 
-        if ($lastChangeOrders !== null && $lastChangeCustomers !== null) {
+        if ($lastChangeOrders !== null) {
-            $this->model_setting_setting->editSetting(
+            $sinceIdOrders = $lastChangeOrders['id'];
-                'retailcrm_history',
+        }
-                [
+
-                    'retailcrm_history_orders' => $lastChangeOrders['id'],
+        if ($lastChangeCustomers !== null) {
-                    'retailcrm_history_customers' => $lastChangeCustomers['id']
+            $sinceIdCustomers = $lastChangeCustomers['id'];
-                ]
-            );
         }
 
-        $orders = RetailcrmHistoryHelper::assemblyOrder($ordersHistory);
-        $customers = RetailcrmHistoryHelper::assemblyCustomer($customersHistory);
-        $newOrders = [];
-        $updatedOrders = [];
         $this->settings = $settings;
+
         $this->status = array_flip($settings[$this->moduleTitle . '_status']);
 
+        $updatedOrders = array();
+        $newOrders = array();
+
         foreach ($orders as $order) {
             if (isset($order['deleted'])) {
                 continue;
@@ -119,7 +126,7 @@ class ModelExtensionRetailcrmHistory extends Model {
 
         unset($orders);
 
-        $updateCustomers = [];
+        $updateCustomers = array();
 
         foreach ($customers as $customer) {
             if (isset($customer['deleted'])) {
@@ -134,27 +141,34 @@ class ModelExtensionRetailcrmHistory extends Model {
         unset($customers);
 
         if (!empty($updateCustomers)) {
-            $customers = $retailcrmApiClient->customersList(['ids' => $updateCustomers]);
+            $customers = $retailcrmApiClient->customersList(array('ids' => $updateCustomers));
             if ($customers) {
                 $this->updateCustomers($customers['customers']);
             }
         }
 
         if (!empty($newOrders)) {
-            $orders = $retailcrmApiClient->ordersList(['ids' => $newOrders]);
+            $orders = $retailcrmApiClient->ordersList(array('ids' => $newOrders));
             if ($orders) {
                 $this->createResult = $this->createOrders($orders['orders'], $retailcrmApiClient);
             }
         }
 
         if (!empty($updatedOrders)) {
-            $orders = $retailcrmApiClient->ordersList(['ids' => $updatedOrders]);
+            $orders = $retailcrmApiClient->ordersList(array('ids' => $updatedOrders));
-
             if ($orders) {
                 $this->updateOrders($orders['orders'], $retailcrmApiClient);
             }
         }
 
+        $this->model_setting_setting->editSetting(
+            'retailcrm_history',
+            array(
+                'retailcrm_history_orders' => $sinceIdOrders,
+                'retailcrm_history_customers' => $sinceIdCustomers
+            )
+        );
+
         if (!empty($this->createResult['customers'])) {
             $retailcrmApiClient->customersFixExternalIds($this->createResult['customers']);
         }

src/upload/admin/model/extension/retailcrm/icml.php

@@ -15,14 +15,13 @@ class ModelExtensionRetailcrmIcml extends Model
 
     /**
      * Constructor
-     *
+     * 
      * @param Registry $registry
      */
     public function __construct($registry)
     {
         parent::__construct($registry);
         $this->load->library('retailcrm/retailcrm');
-        $this->load->model('localisation/weight_class');
     }
 
     public function generateICML()
@@ -78,7 +77,7 @@ class ModelExtensionRetailcrmIcml extends Model
      */
     private function addCategories()
     {
-        $categories = $this->model_catalog_category->getCategories([]);
+        $categories = $this->model_catalog_category->getCategories(array());
         foreach ($categories as $category) {
             $category = $this->model_catalog_category->getCategory($category['category_id']);
 
@@ -103,18 +102,11 @@ class ModelExtensionRetailcrmIcml extends Model
     }
 
     private function addOffers() {
-        $offerManufacturers = [];
+        $offerManufacturers = array();
-        $servicesForIcml = $this->retailcrm->useServicesForIcml();
         $currencyForIcml = $this->retailcrm->getCurrencyForIcml();
         $defaultCurrency = $this->getDefaultCurrency();
         $settingLenght = $this->retailcrm->getLenghtForIcml();
         $leghtsArray = $this->model_localisation_length_class->getLengthClasses();
-        $weightClassesMas = $this->model_localisation_weight_class->getWeightClasses();
-        $weightClasses = [];
-
-        foreach ($weightClassesMas as $weightClass) {
-            $weightClasses[$weightClass['weight_class_id']]['value'] = $weightClass['value'];
-        }
 
         foreach ($leghtsArray as $lenght) {
             if ($lenght['value'] == 1) {
@@ -123,20 +115,20 @@ class ModelExtensionRetailcrmIcml extends Model
         }
 
         $manufacturers = $this->model_catalog_manufacturer
-            ->getManufacturers([]);
+            ->getManufacturers(array());
 
         foreach ($manufacturers as $manufacturer) {
             $offerManufacturers[$manufacturer['manufacturer_id']] = $manufacturer['name'];
         }
 
-        $products = $this->model_catalog_product->getProducts([]);
+        $products = $this->model_catalog_product->getProducts(array());
 
         foreach ($products as $product) {
             $offers = $this->retailcrm->getOffers($product);
 
             foreach ($offers as $optionsString => $optionsValues) {
                 $optionsString = explode('_', $optionsString);
-                $options = [];
+                $options = array();
 
                 foreach($optionsString as $optionString) {
                     $option = explode('-', $optionString);
@@ -151,43 +143,35 @@ class ModelExtensionRetailcrmIcml extends Model
                                 'value_id' => $option[1],
                                 'option_id' => $optionIds[1]
                             );
-                        }
+                        }                     
                     }
                 }
 
                 ksort($options);
 
-                $offerId = [];
+                $offerId = array();
 
                 foreach($options as $optionKey => $optionData) {
                     $offerId[] = $optionKey.'-'.$optionData['value_id'];
                 }
 
                 $offerId = implode('_', $offerId);
-                $catalog = $this->eOffers->appendChild($this->dd->createElement('offer'));
+                $e = $this->eOffers->appendChild($this->dd->createElement('offer'));
 
                 if (!empty($offerId)) {
-                    $catalog->setAttribute('id', $product['product_id'] . '#' . $offerId);
+                    $e->setAttribute('id', $product['product_id'] . '#' . $offerId);
-                    $catalog->setAttribute('productId', $product['product_id']);
+                    $e->setAttribute('productId', $product['product_id']);
-                    $catalog->setAttribute('quantity', $optionsValues['qty']);
+                    $e->setAttribute('quantity', $optionsValues['qty']);
                 } else {
-                    $catalog->setAttribute('id', $product['product_id']);
+                    $e->setAttribute('id', $product['product_id']);
-                    $catalog->setAttribute('productId', $product['product_id']);
+                    $e->setAttribute('productId', $product['product_id']);
-                    $catalog->setAttribute('quantity', $product['quantity']);
+                    $e->setAttribute('quantity', $product['quantity']);
                 }
-
-                /**
-                 * Set type for offers
-                 */
-                $useServices = $servicesForIcml && isset($product['shipping']) && $product['shipping'] == 0;
-
-                $catalog->setAttribute('type', $useServices ? 'service' : 'product');
-
                 /**
                  * Offer activity
                  */
                 $activity = $product['status'] == 1 ? 'Y' : 'N';
-                $catalog->appendChild(
+                $e->appendChild(
                     $this->dd->createElement('productActivity')
                 )->appendChild(
                     $this->dd->createTextNode($activity)
@@ -199,7 +183,7 @@ class ModelExtensionRetailcrmIcml extends Model
                     ->getProductCategories($product['product_id']);
                 if (!empty($categories)) {
                     foreach ($categories as $category) {
-                        $catalog->appendChild($this->dd->createElement('categoryId'))
+                        $e->appendChild($this->dd->createElement('categoryId'))
                             ->appendChild(
                                 $this->dd->createTextNode($category)
                             );
@@ -208,18 +192,18 @@ class ModelExtensionRetailcrmIcml extends Model
                 /**
                  * Name & price
                  */
-                $catalog->appendChild($this->dd->createElement('productName'))
+                $e->appendChild($this->dd->createElement('productName'))
                     ->appendChild($this->dd->createTextNode($product['name']));
                 if (!empty($options)) {
-                    $optionsString = [];
+                    $optionsString = array();
                     foreach($options as $option) {
                         $optionsString[] = $option['name'].': '.$option['value'];
                     }
                     $optionsString = ' ('.implode(', ', $optionsString).')';
-                    $catalog->appendChild($this->dd->createElement('name'))
+                    $e->appendChild($this->dd->createElement('name'))
                         ->appendChild($this->dd->createTextNode($product['name'].$optionsString));
                 } else {
-                    $catalog->appendChild($this->dd->createElement('name'))
+                    $e->appendChild($this->dd->createElement('name'))
                         ->appendChild($this->dd->createTextNode($product['name']));
                 }
 
@@ -233,13 +217,13 @@ class ModelExtensionRetailcrmIcml extends Model
                     $price = $product['price'] + $optionsValues['price'];
                 }
 
-                $catalog->appendChild($this->dd->createElement('price'))
+                $e->appendChild($this->dd->createElement('price'))
                     ->appendChild($this->dd->createTextNode($price));
                 /**
                  * Vendor
                  */
                 if ($product['manufacturer_id'] != 0) {
-                    $catalog->appendChild($this->dd->createElement('vendor'))
+                    $e->appendChild($this->dd->createElement('vendor'))
                         ->appendChild(
                             $this->dd->createTextNode(
                                 $offerManufacturers[$product['manufacturer_id']]
@@ -280,7 +264,7 @@ class ModelExtensionRetailcrmIcml extends Model
                         $productHeight
                     );
 
-                    $catalog->appendChild($this->dd->createElement('dimensions'))
+                    $e->appendChild($this->dd->createElement('dimensions'))
                         ->appendChild($this->dd->createTextNode($dimensions));
                 }
 
@@ -289,14 +273,14 @@ class ModelExtensionRetailcrmIcml extends Model
                  */
                 if ($product['image']) {
                     $image = $this->generateImage($product['image']);
-                    $catalog->appendChild($this->dd->createElement('picture'))
+                    $e->appendChild($this->dd->createElement('picture'))
                         ->appendChild($this->dd->createTextNode($image));
                 }
                 /**
                  * Url
                  */
                 $this->url = new Url(HTTP_CATALOG, HTTPS_CATALOG);
-                $catalog->appendChild($this->dd->createElement('url'))
+                $e->appendChild($this->dd->createElement('url'))
                     ->appendChild(
                         $this->dd->createTextNode(
                             $this->url->link(
@@ -314,7 +298,7 @@ class ModelExtensionRetailcrmIcml extends Model
                         $param->setAttribute('code', $optionData['option_id']);
                         $param->setAttribute('name', $optionData['name']);
                         $param->appendChild($this->dd->createTextNode($optionData['value']));
-                        $catalog->appendChild($param);
+                        $e->appendChild($param);
                     }
                 }
                 if ($product['sku']) {
@@ -322,24 +306,24 @@ class ModelExtensionRetailcrmIcml extends Model
                     $sku->setAttribute('code', 'article');
                     $sku->setAttribute('name', $this->language->get('article'));
                     $sku->appendChild($this->dd->createTextNode($product['sku']));
-                    $catalog->appendChild($sku);
+                    $e->appendChild($sku);
                 }
                 if ($product['weight'] != '') {
-                    $weight = $this->dd->createElement('weight');
+                    $weight = $this->dd->createElement('param');
-                    $coeffWeight = 1;
+                    $weight->setAttribute('code', 'weight');
-
+                    $weight->setAttribute('name', $this->language->get('weight'));
-                    if (!empty($weightClasses[$product['weight_class_id']]['value'])) {
+                    if (!empty($optionsValues['weight'])) {
-                        $coeffWeight = $weightClasses[$product['weight_class_id']]['value'];
+                        $weightValue = round($product['weight'] + $optionsValues['weight'], 3);
+                    } else {
+                        $weightValue = round($product['weight'], 3);
                     }
 
-                    $weightValue = !empty($optionsValues['weight'])
+                    if (isset($product['weight_class'])) {
-                        ? $product['weight'] + $optionsValues['weight']
+                        $weightValue = $weightValue . ' ' . $product['weight_class'];
-                        : $product['weight']
+                    }
-                    ;
-                    $weightValue = round($weightValue / $coeffWeight, 6);
 
                     $weight->appendChild($this->dd->createTextNode($weightValue));
-                    $catalog->appendChild($weight);
+                    $e->appendChild($weight);
                 }
             }
         }
@@ -352,7 +336,7 @@ class ModelExtensionRetailcrmIcml extends Model
     private function generateImage($image)
     {
         $this->load->model('tool/image');
-
+ 
         $currentTheme = $this->config->get('config_theme');
         $width = $this->config->get($currentTheme . '_image_related_width') ? $this->config->get($currentTheme . '_image_related_width') : 200;
         $height = $this->config->get($currentTheme . '_image_related_height') ? $this->config->get($currentTheme . '_image_related_height') : 200;

src/upload/admin/model/extension/retailcrm/references.php

@@ -158,22 +158,6 @@ class ModelExtensionRetailcrmReferences extends Model
         return (!$response->isSuccessful()) ? array() : $response->deliveryTypes;
     }
 
-    /**
-     * Get RetailCRM available sites list
-     */
-    public function getApiSite()
-    {
-        $response = $this->retailcrmApiClient->sitesList();
-
-        if (!$response || !$response->isSuccessful()) {
-            return [];
-        }
-
-        $sites = $response->sites;
-
-        return end($sites);
-    }
-
     /**
      * Get RetailCRM order statuses
      *

src/upload/admin/view/stylesheet/retailcrm.css

@@ -1,11 +1,5 @@
 .retailcrm_unit {margin-bottom: 10px;}
-.retailcrm_disable_border {border: none !important;}
 .retailcrm_unit input {width: 30%;}
 .checkbox input{width: auto;}
 .retailcrm_unit input[type=checkbox] {width: 13px;}
-.retailcrm_unit select {max-width: 500px;}
+.retailcrm_unit select {max-width: 500px;}
-
-.question-mark {
-    cursor: help;
-    position: relative;
-}

src/upload/admin/view/template/extension/module/retailcrm.tpl

@@ -97,22 +97,7 @@
                 </div>
               </fieldset>
               <fieldset>
-                <legend><?php echo $icml_settings; ?></legend>
+                <legend><?php echo $text_currency; ?></legend>
-                <div class="form-group retailcrm_unit">
-                  <label class="col-sm-2 control-label question-mark" for="retailcrm_icml_service_enabled" title="When the option is enabled, all products for which delivery is disabled will be considered as services and uploaded to CRM as services"><?php echo $icml_service_enabled_label; ?></label>
-                  <div class="col-sm-10">
-                    <label class="radio-inline">
-                      <input type="radio" name="retailcrm_icml_service_enabled value="1"
-                      <?php if(isset($saved_settings['retailcrm_icml_service_enabled']) && $saved_settings['retailcrm_icml_service_enabled'] == 1): echo 'checked'; endif;?>/>
-                      <?php echo $text_yes; ?>
-                    </label>
-                    <label class="radio-inline">
-                      <input type="radio" name="retailcrm_icml_service_enabled" value="0"
-                      <?php if(!isset($saved_settings['retailcrm_icml_service_enabled']) || $saved_settings['retailcrm_icml_service_enabled'] == 0): echo 'checked'; endif;?>/>
-                      <?php echo $text_no; ?>
-                    </label>
-                  </div>
-                </div
                 <div class="form-group retailcrm_unit">
                   <label class="col-sm-2 control-label"><?php echo $text_currency; ?></label>
                   <div class="col-md-4 col-sm-10">
@@ -127,6 +112,9 @@
                     </select>
                   </div>
                 </div>
+              </fieldset>
+              <fieldset>
+                <legend><?php echo $text_lenght; ?></legend>
                 <div class="form-group retailcrm_unit">
                   <label class="col-sm-2 control-label"><?php echo $text_lenght_label; ?></label>
                   <div class="col-md-4 col-sm-10">
@@ -225,26 +213,6 @@
                   </div>
                 </div>
               </fieldset>
-              <fieldset>
-                <legend><?php echo $summ_around; ?></legend>
-                <div class="form-group">
-                  <label class="col-sm-2 control-label" for="retailcrm_summ_around"><?php echo $text_summ_around; ?></label>
-                  <div class="col-sm-10">
-                    <label class="radio-inline">
-                      <input type="radio" name="retailcrm_summ_around" value="1" <?php if (isset($saved_settings['retailcrm_summ_around']) &&
-                      $saved_settings['retailcrm_summ_around'] == 1) :
-                      echo 'checked'; endif; ?> />
-                      <?php echo $text_yes; ?>
-                    </label>
-                    <label class="radio-inline">
-                      <input type="radio" name="retailcrm_summ_around" value="0" <?php if (!isset($saved_settings['retailcrm_summ_around']) ||
-                      $saved_settings['retailcrm_summ_around'] == 0) :
-                      echo 'checked'; endif; ?> />
-                      <?php echo $text_no; ?>
-                    </label>
-                  </div>
-                </div>
-              </fieldset>
               <fieldset>
                 <legend><?php echo $text_retailcrm_discount; ?></legend>
                 <div class="form-group">

src/upload/admin/view/template/extension/module/retailcrm.twig

@@ -9,7 +9,7 @@
                 <button type="button" id="icml" data-toggle="tooltip" title="{{ text_button_catalog }}" class="btn btn-success"><i class="fa fa-file-text-o"></i></button>
                 <button type="submit" form="form-module" data-toggle="tooltip" title="{{ button_save }}" class="btn btn-primary"><i class="fa fa-save"></i></button>
                 <a href="{{ cancel }}" data-toggle="tooltip" title="{{ button_cancel }}" class="btn btn-default"><i class="fa fa-reply"></i></a></div>
-            <h1>{{ heading_title }} {{ module_version }}</h1>
+            <h1>{{ heading_title }}</h1>
             <ul class="breadcrumb">
                 {% for breadcrumb in breadcrumbs %}
                     <li><a href="{{ breadcrumb.href }}">{{ breadcrumb.text }}</a></li>
@@ -55,7 +55,7 @@
                                         <input class="form-control" id="retailcrm_url" type="text" name="module_retailcrm_url" value="{% if saved_settings.module_retailcrm_url is defined %}{{ saved_settings.module_retailcrm_url }}{% endif %}">
                                     </div>
                                 </div>
-                                <div class="form-group retailcrm_unit retailcrm_disable_border">
+                                <div class="form-group retailcrm_unit">
                                     <label class="col-sm-2 control-label" for="retailcrm_apikey">{{ retailcrm_apikey }}</label>
                                     <div class="col-lg-4 col-md-6 col-sm-10">
                                         <input class="form-control" id="retailcrm_apikey" type="text" name="module_retailcrm_apikey" value="{% if saved_settings.module_retailcrm_apikey is defined %}{{ saved_settings.module_retailcrm_apikey }}{% endif %}">
@@ -100,27 +100,8 @@
                                 </div>
                             </fieldset>
                             <fieldset>
-                                <legend>{{ icml_settings }}</legend>
+                                <legend>{{ text_currency }}</legend>
-                                <div class="form-group retailcrm_unit retailcrm_disable_border">
+                                <div class="form-group retailcrm_unit">
-                                    <label class="col-sm-2 control-label question-mark" for="module_retailcrm_icml_service_enabled" title="{{ icml_service_description }}">{{ icml_service_enabled_label }}</label>
-                                    <div class="col-sm-10">
-                                        <label class="radio-inline">
-                                            <input type="radio" name="module_retailcrm_icml_service_enabled" value="1"
-                                                    {% if saved_settings.module_retailcrm_icml_service_enabled is defined and saved_settings.module_retailcrm_icml_service_enabled == 1 %}
-                                                        checked
-                                                    {% endif %} />
-                                            {{ text_yes }}
-                                        </label>
-                                        <label class="radio-inline">
-                                            <input type="radio" name="module_retailcrm_icml_service_enabled" value="0"
-                                                    {% if saved_settings.module_retailcrm_icml_service_enabled is not defined or saved_settings.module_retailcrm_icml_service_enabled == 0 %}
-                                                        checked
-                                                    {% endif %} />
-                                            {{ text_no }}
-                                        </label>
-                                    </div>
-                                </div>
-                                <div class="form-group retailcrm_unit retailcrm_disable_border">
                                     <label class="col-sm-2 control-label">{{ text_currency_label }}</label>
                                     <div class="col-md-4 col-sm-10">
                                         <select id="module_retailcrm_currency" name="module_retailcrm_currency" class="form-control">
@@ -134,14 +115,17 @@
                                         </select>
                                     </div>
                                 </div>
-                                <div class="form-group retailcrm_unit retailcrm_disable_border">
+                            </fieldset>
+                            <fieldset>
+                                <legend>{{ text_lenght }}</legend>
+                                <div class="form-group retailcrm_unit">
                                     <label class="col-sm-2 control-label">{{ text_lenght_label }}</label>
                                     <div class="col-md-4 col-sm-10">
                                         <select id="module_retailcrm_lenght" name="module_retailcrm_lenght" class="form-control">
                                             {% for lenght in lenghts %}
-                                                <option value="{{ lenght.length_class_id }}" {% if saved_settings.module_retailcrm_lenght is defined and saved_settings.module_retailcrm_lenght == lenght.length_class_id %} selected="selected" {% endif %}>
+                                                    <option value="{{ lenght.length_class_id }}" {% if saved_settings.module_retailcrm_lenght is defined and saved_settings.module_retailcrm_lenght == lenght.length_class_id %} selected="selected" {% endif %}>
-                                                    {{ lenght.title }}
+                                                        {{ lenght.title }}
-                                                </option>
+                                                    </option>
                                             {% endfor %}
                                         </select>
                                     </div>
@@ -236,28 +220,6 @@
                                     </div>
                                 </div>
                             </fieldset>
-                            <fieldset>
-                                <legend>{{ summ_around }}</legend>
-                                <div class="form-group">
-                                    <label class="col-sm-2 control-label" class="col-sm-2 control-label" for="module_retailcrm_summ_around">{{ text_summ_around }}</label>
-                                    <div class="col-sm-10">
-                                        <label class="control-label" class="radio-inline">
-                                            <input type="radio" name="module_retailcrm_summ_around" value="1"
-                                                    {% if saved_settings.module_retailcrm_summ_around is defined and saved_settings.module_retailcrm_summ_around == 1 %}
-                                                        checked
-                                                    {% endif %} />
-                                            {{ text_yes }}
-                                        </label>
-                                        <label class="control-label" class="radio-inline">
-                                            <input type="radio" name="module_retailcrm_summ_around" value="0"
-                                                    {% if saved_settings.module_retailcrm_summ_around is not defined or saved_settings.module_retailcrm_summ_around == 0 %}
-                                                        checked
-                                                    {% endif %} />
-                                            {{ text_no }}
-                                        </label>
-                                    </div>
-                                </div>
-                            </fieldset>
                             <fieldset>
                                 <legend>{{ text_retailcrm_discount }}</legend>
                                 <div class="form-group">

src/upload/catalog/controller/extension/module/retailcrm.php

@@ -138,20 +138,6 @@ class ControllerExtensionModuleRetailcrm extends Controller {
         }
     }
 
-    public function customer_edit_newsletter($parameter1, $parameter2, $parameter3)
-    {
-        $customerId = $this->customer->getId();
-        $customer = $this->model_account_customer->getCustomer($customerId);
-
-        if (file_exists(DIR_APPLICATION . 'model/extension/retailcrm/custom/customer.php')) {
-            $this->load->model('extension/retailcrm/custom/customer');
-            $this->model_extension_retailcrm_custom_customer->changeInCrm($customer, $this->retailcrmApiClient);
-        } else {
-            $customer_manager = $this->retailcrm->getCustomerManager();
-            $customer_manager->editCustomerNewsLetter($customer);
-        }
-    }
-
     /**
      * Update customer on event
      *

src/upload/catalog/model/extension/retailcrm/order.php

@@ -136,12 +136,6 @@ class ModelExtensionRetailcrmOrder extends Model {
             $order['number'] = $order_data['order_id'];
         }
 
-        if (isset($this->settings[$this->moduleTitle . '_summ_around'])
-            && $this->settings[$this->moduleTitle . '_summ_around'] == 1
-        ) {
-            $order['applyRound'] = true;
-        }
-
         $order['externalId'] = $order_id;
         $order['firstName'] = $order_data['shipping_firstname'];
         $order['lastName'] = $order_data['shipping_lastname'];
@@ -426,7 +420,6 @@ class ModelExtensionRetailcrmOrder extends Model {
             'lastName' => $data['lastname'],
             'email' => $data['email'],
             'createdAt' => $data['date_added'],
-            'externalId' => $data['customer_id'],
             'address' => array(
                 'countryIso' => $data['payment_iso_code_2'],
                 'index' => $data['payment_postcode'],

src/upload/system/library/retailcrm/lib/api/RetailcrmApiClient5.php

@@ -584,18 +584,30 @@ class RetailcrmApiClient5
 
     /**
      * Get orders history
-     *
      * @param array $filter
-     * @param int|null $limit
+     * @param null $page
+     * @param null $limit
      *
      * @return ApiResponse
      */
-    public function ordersHistory(array $filter = [], ?int $limit = 100)
+    public function ordersHistory(array $filter = array(), $page = null, $limit = null)
     {
+        $parameters = array();
+
+        if (count($filter)) {
+            $parameters['filter'] = $filter;
+        }
+        if (null !== $page) {
+            $parameters['page'] = (int) $page;
+        }
+        if (null !== $limit) {
+            $parameters['limit'] = (int) $limit;
+        }
+
         return $this->client->makeRequest(
             '/orders/history',
             RetailcrmHttpClient::METHOD_GET,
-            ['filter' => $filter, 'limit' => $limit]
+            $parameters
         );
     }
 
@@ -896,18 +908,30 @@ class RetailcrmApiClient5
 
     /**
      * Get customers history
-     *
      * @param array $filter
-     * @param int|null $limit
+     * @param null $page
+     * @param null $limit
      *
      * @return ApiResponse
      */
-    public function customersHistory(array $filter = [], ?int $limit = 100)
+    public function customersHistory(array $filter = array(), $page = null, $limit = null)
     {
+        $parameters = array();
+
+        if (count($filter)) {
+            $parameters['filter'] = $filter;
+        }
+        if (null !== $page) {
+            $parameters['page'] = (int) $page;
+        }
+        if (null !== $limit) {
+            $parameters['limit'] = (int) $limit;
+        }
+
         return $this->client->makeRequest(
             '/customers/history',
             RetailcrmHttpClient::METHOD_GET,
-            ['filter' => $filter, 'limit' => $limit]
+            $parameters
         );
     }
 
@@ -1084,17 +1108,34 @@ class RetailcrmApiClient5
     /**
      * Get orders assembly history
      *
-     * @param array $filter
+     * @param array $filter (default: array())
-     * @param int|null $limit
+     * @param int   $page   (default: null)
+     * @param int   $limit  (default: null)
+     *
+     * @throws \InvalidArgumentException
+     * @throws \RetailCrm\Exception\CurlException
+     * @throws \RetailCrm\Exception\InvalidJsonException
      *
      * @return ApiResponse
      */
-    public function ordersPacksHistory(array $filter = [], ?int $limit = 100)
+    public function ordersPacksHistory(array $filter = array(), $page = null, $limit = null)
     {
+        $parameters = array();
+
+        if (count($filter)) {
+            $parameters['filter'] = $filter;
+        }
+        if (null !== $page) {
+            $parameters['page'] = (int) $page;
+        }
+        if (null !== $limit) {
+            $parameters['limit'] = (int) $limit;
+        }
+
         return $this->client->makeRequest(
             '/orders/packs/history',
             RetailcrmHttpClient::METHOD_GET,
-            ['filter' => $filter, 'limit' => $limit]
+            $parameters
         );
     }
 
@@ -2411,18 +2452,30 @@ class RetailcrmApiClient5
 
     /**
      * Get corporate customers history
-     *
      * @param array $filter
-     * @param int|null $limit
+     * @param null $page
+     * @param null $limit
      *
-     * @return ApiResponse
+     * @return \ApiResponse
      */
-    public function customersCorporateHistory(array $filter = [], ?int $limit = 100)
+    public function customersCorporateHistory(array $filter = [], $page = null, $limit = null)
     {
+        $parameters = [];
+
+        if (count($filter)) {
+            $parameters['filter'] = $filter;
+        }
+        if (null !== $page) {
+            $parameters['page'] = (int) $page;
+        }
+        if (null !== $limit) {
+            $parameters['limit'] = (int) $limit;
+        }
+
         return $this->client->makeRequest(
             '/customers-corporate/history',
             RetailcrmHttpClient::METHOD_GET,
-            ['filter' => $filter, 'limit' => $limit]
+            $parameters
         );
     }
 

src/upload/system/library/retailcrm/lib/api/RetailcrmHttpClient.php

@@ -1,7 +1,5 @@
 <?php
 
-use retailcrm\Retailcrm;
-
 class RetailcrmHttpClient
 {
     const METHOD_GET = 'GET';
@@ -48,9 +46,9 @@ class RetailcrmHttpClient
     public function makeRequest(
         $path,
         $method,
-        array $parameters = []
+        array $parameters = array()
     ) {
-        $allowedMethods = [self::METHOD_GET, self::METHOD_POST];
+        $allowedMethods = array(self::METHOD_GET, self::METHOD_POST);
 
         if (!in_array($method, $allowedMethods, false)) {
             throw new \InvalidArgumentException(
@@ -62,16 +60,7 @@ class RetailcrmHttpClient
             );
         }
 
-    
+        $parameters = array_merge($this->defaultParameters, $parameters);
-        $parameters = self::METHOD_GET === $method
-            ? array_merge($this->defaultParameters, $parameters, [
-                'cms_source' => 'OpenCart',
-                'cms_version' => VERSION,
-                'php_version' => function_exists('phpversion') ? phpversion() : '',
-                'module_version' => Retailcrm::VERSION_MODULE,
-            ])
-            : $parameters = array_merge($this->defaultParameters, $parameters);
-        
 
         $url = $this->url . $path;
 

src/upload/system/library/retailcrm/lib/api/RetailcrmProxy.php

@@ -6,7 +6,7 @@
  * @method ordersCreate($order, $site = null)
  * @method ordersEdit($order, $by = 'externalId', $site = null)
  * @method ordersGet($order, $by = 'externalId', $site = null)
- * @method ordersList(array $filter = [], $page = null, $limit = null)
+ * @method ordersList($filter, $page, $limit)
  * @method customersCreate($customer, $site = null)
  * @method customersEdit($customer, $by = 'externalId', $site = null)
  * @method customersList(array $filter = [], $page = null, $limit = null)
@@ -27,16 +27,16 @@ class RetailcrmProxy {
 
     public function __construct($url, $key) {
         $this->api = new RetailcrmApiClient5($url, $key);
+
         $this->log = new \Log('retailcrm.log');
     }
 
     public function __call($method, $arguments) {
         try {
-            $response = call_user_func_array([$this->api, $method], $arguments);
+            $response = call_user_func_array(array($this->api, $method), $arguments);
 
             if (!$response->isSuccessful()) {
                 $this->log->write(sprintf("[%s] %s", $method, $response->getErrorMsg()));
-
                 if (isset($response['errors'])) {
                     $error = implode("\n", $response['errors']);
                     $this->log->write($error . "\n");

src/upload/system/library/retailcrm/lib/history/Customer.php

@@ -38,14 +38,10 @@ class Customer {
         }
 
         $customer_data['firstname'] = $customer['firstName'];
-        $customer_data['lastname'] = $customer['lastName'] ?? '';
+        $customer_data['lastname'] = isset($customer['lastName']) ? $customer['lastName'] : '';
         $customer_data['email'] = $customer['email'];
         $customer_data['telephone'] = $customer['phones'] ? $customer['phones'][0]['number'] : '';
 
-        if (!empty($customer['emailMarketingUnsubscribedAt'])) {
-            $customer_data['newsletter'] = 0;
-        }
-
         $customer_data['affiliate'] = false;
     }
 
@@ -113,7 +109,7 @@ class Customer {
                 }
             }
 
-            $customer_data['custom_field'] = $custom_fields ?? [];
+            $customer_data['custom_field'] = isset($custom_fields) ? $custom_fields : '';
         }
     }
 }

src/upload/system/library/retailcrm/lib/repository/DataRepository.php

@@ -124,7 +124,6 @@ class DataRepository extends \retailcrm\Base {
      * @return array
      */
     public function getZoneByName($name) {
-        $name = $this->db->escape($name);
         $query = $this->db->query("SELECT * FROM `" . DB_PREFIX . "zone` WHERE name = '" . $name . "'");
 
         return $query->row;

src/upload/system/library/retailcrm/lib/service/CustomerManager.php

@@ -12,7 +12,7 @@ class CustomerManager {
     }
 
     public function createCustomer($customer_data, $address) {
-        $customer = $this->prepareCustomer($customer_data, $address, !empty($customer_data['newsletter']));
+        $customer = $this->prepareCustomer($customer_data, $address);
 
         $this->api->customersCreate($customer);
     }
@@ -23,22 +23,13 @@ class CustomerManager {
         $this->api->customersEdit($customer);
     }
 
-    public function editCustomerNewsLetter($customer_data) {
-        $this->api->customersEdit(
-            [
-                'externalId' => $customer_data['customer_id'],
-                'subscribed' => !empty($customer_data['newsletter']),
-            ]
-        );
-    }
-
     public function uploadCustomers($customers) {
         $this->api->customersUpload($customers);
     }
 
-    public function prepareCustomer($customer_data, $address, $isSubscribed = null) {
+    public function prepareCustomer($customer_data, $address) {
         return $this->customer_converter
-            ->initCustomerData($customer_data, $address, $isSubscribed)
+            ->initCustomerData($customer_data, $address)
             ->setCustomerData()
             ->setAddress()
             ->setCustomFields()

src/upload/system/library/retailcrm/lib/service/RetailcrmCustomerConverter.php

@@ -4,9 +4,9 @@ namespace retailcrm\service;
 
 class RetailcrmCustomerConverter {
     protected $data;
-    protected $customer_data = [];
+    protected $customer_data = array();
-    protected $address = [];
+    protected $address = array();
-    protected $isSubscribed;
+
     protected $settingsManager;
 
     public function __construct(
@@ -19,11 +19,10 @@ class RetailcrmCustomerConverter {
         return $this->data;
     }
 
-    public function initCustomerData($customer_data, $address, $isSubscribed) {
+    public function initCustomerData($customer_data, $address) {
-        $this->data = [];
+        $this->data = array();
         $this->customer_data = $customer_data;
         $this->address = $address;
-        $this->isSubscribed = $isSubscribed;
 
         return $this;
     }
@@ -35,12 +34,12 @@ class RetailcrmCustomerConverter {
         $this->data['email'] = $this->customer_data['email'];
         $this->data['createdAt'] = $this->customer_data['date_added'];
 
-        if ($this->isSubscribed !== null) {
-            $this->data['subscribed'] = $this->isSubscribed;
-        }
-
         if (!empty($this->customer_data['telephone'])) {
-            $this->data['phones'] = [['number' => $this->customer_data['telephone']]];
+            $this->data['phones'] = array(
+                array(
+                    'number' => $this->customer_data['telephone']
+                )
+            );
         }
 
         return $this;
@@ -48,13 +47,13 @@ class RetailcrmCustomerConverter {
 
     public function setAddress() {
         if (!empty($this->address)) {
-            $this->data['address'] = [
+            $this->data['address'] = array(
                 'index' => $this->address['postcode'],
                 'countryIso' => $this->address['iso_code_2'],
                 'region' => $this->address['zone'],
                 'city' => $this->address['city'],
                 'text' => $this->address['address_1'] . ' ' . $this->address['address_2']
-            ];
+            );
         }
 
         return $this;

src/upload/system/library/retailcrm/lib/service/RetailcrmOrderConverter.php

@@ -43,14 +43,12 @@ class RetailcrmOrderConverter {
             $this->data['countryIso'] = $this->order_data['shipping_iso_code_2'];
         }
 
-        if ($this->settingsManager->getSetting('order_number') == 1) {
+        if ($this->settingsManager->getSetting('order_number')
+            && $this->settingsManager->getSetting('order_number') == 1
+        ) {
             $this->data['number'] = $this->order_data['order_id'];
         }
 
-        if ($this->settingsManager->getSetting('summ_around') == 1) {
-            $this->data['applyRound'] = true;
-        }
-
         $this->data['externalId'] = $this->order_data['order_id'];
         $this->data['firstName'] = $this->order_data['shipping_firstname'];
         $this->data['lastName'] = $this->order_data['shipping_lastname'];

src/upload/system/library/retailcrm/objects.xml

@@ -14,7 +14,6 @@
         <field id="cumulative_discount" group="customer">cumulativeDiscount</field>
         <field id="personal_discount" group="customer">personalDiscount</field>
         <field id="discount_card_number" group="customer">discountCardNumber</field>
-        <field id="email_marketing_unsubscribed_at" group="customer">emailMarketingUnsubscribedAt</field>
         
         <field id="address.index" group="customerAddress">index</field>
         <field id="address.country" group="customerAddress">country</field>

src/upload/system/library/retailcrm/retailcrm.php

@@ -16,7 +16,6 @@ class Retailcrm {
 
     const RETAILCRM_DISCOUNT = 'retailcrm_discount';
     const RETAILCRM_DISCOUNT_SORT_ORDER = 8;
-    const VERSION_MODULE = '4.1.19';
 
     protected $registry;
 
@@ -243,15 +242,6 @@ class Retailcrm {
         return false;
     }
 
-    public function useServicesForIcml()
-    {
-        $this->load->model('setting/setting');
-
-        $setting = $this->model_setting_setting->getSetting($this->getModuleTitle());
-
-        return $setting['module_retailcrm_icml_service_enabled'] ?? false;
-    }
-
     /**
      * @return mixed
      */

tests/admin/ControllerRetailcrmAdminTest.php

@@ -41,63 +41,4 @@ class ControllerRetailcrmAdminTest extends TestCase
         $response = $this->dispatchAction('extension/module/retailcrm/uninstall_collector');
         $this->assertRegExp('/Connection settings/', $response->getOutput());
     }
-
-    public function testGetAvailableTypes()
-    {
-        $data = $this->getDataForTestAvailableTypes();
-        $sites = end($data['site']);
-        $types = $data['types'];
-
-        $retailCrm = new ControllerExtensionModuleRetailcrm(self::$registry);
-        $class = new ReflectionClass($retailCrm);
-        $method = $class->getMethod('getAvailableTypes');
-        $method->setAccessible(true);
-
-        $result = $method->invokeArgs($retailCrm, [$sites, $types]);
-
-        $this->assertNotEmpty($result['opencart']);
-        $this->assertNotEmpty($result['retailcrm']);
-        $this->assertCount(2, $result['retailcrm']);
-        $this->assertNotEmpty($result['retailcrm']['test1']['code']);
-        $this->assertNotEmpty($result['retailcrm']['test4']['code']);
-    }
-
-    private function getDataForTestAvailableTypes(): array
-    {
-        return [
-            'site' => [
-                'opencart' => [
-                    'code' => 'opencart',
-                    'name' => 'OpenCart'
-                ]
-            ],
-            'types' => [
-                'opencart' => [
-                    'test'
-                ],
-                'retailcrm' => [
-                    'test1' => [
-                        'active' => true,
-                        'sites' => [],
-                        'code' => 'test1'
-                    ],
-                    'test2' => [
-                        'active' => false,
-                        'sites' => [],
-                        'code' => 'test2'
-                    ],
-                    'test3' => [
-                        'active' => true,
-                        'sites' => ['otherSite'],
-                        'code' => 'test3'
-                    ],
-                    'test4' => [
-                        'active' => true,
-                        'sites' => ['cms1', 'cms2', 'opencart'],
-                        'code' => 'test4'
-                    ]
-                ]
-            ]
-        ];
-    }
 }

tests/system/lib/repository/DataRepositoryAdminTest.php

@@ -19,8 +19,6 @@ class DataRepositoryAdminTest extends TestCase {
 
         $this->assertNotEmpty($zone);
         $this->assertNotEmpty($zone['zone_id']);
-
-        $repository->getZoneByName('Rostov-na-Do\'nu');
     }
 
     public function testGetCurrencyByCode() {

tests/system/lib/service/RetailcrmCustomerConverterTest.php

@@ -11,7 +11,7 @@ class RetailcrmCustomerConverterTest extends TestCase {
         $customer_data = $model->getCustomer(1);
 
         $customer = $converter
-            ->initCustomerData($customer_data, [], true)
+            ->initCustomerData($customer_data, array())
             ->setCustomerData()
             ->getCustomer();
 
@@ -20,24 +20,23 @@ class RetailcrmCustomerConverterTest extends TestCase {
         $this->assertEquals($customer_data['lastname'], $customer['lastName']);
         $this->assertEquals($customer_data['email'], $customer['email']);
         $this->assertEquals($customer_data['date_added'], $customer['createdAt']);
-        $this->assertTrue($customer['subscribed']);
     }
 
     public function testSetAddress() {
         $converter = \retailcrm\factory\CustomerConverterFactory::create(static::$registry);
         $model = $this->loadModel('account/customer');
         $customer_data = $model->getCustomer(static::CUSTOMER_ID);
-        $address = [
+        $address = array(
             'postcode' => '111111',
             'iso_code_2' => 'EN',
             'zone' => 'Zone',
             'city' => 'City',
             'address_1' => 'Address',
             'address_2' => ''
-        ];
+        );
 
         $customer = $converter
-            ->initCustomerData($customer_data, $address, null)
+            ->initCustomerData($customer_data, $address)
             ->setAddress()
             ->getCustomer();