From 5fc6e4c5b89328c5f7b4a0af41777735e93eb3eb Mon Sep 17 00:00:00 2001 From: max-baranikov Date: Mon, 21 Jun 2021 16:39:50 +0300 Subject: [PATCH] Added a check for the existence of logs folder. Do not report about abandoned carts state in logs --- retailcrm/lib/RetailcrmLogger.php | 15 ++++++++++++--- .../lib/events/RetailcrmAbandonedCartsEvent.php | 2 +- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/retailcrm/lib/RetailcrmLogger.php b/retailcrm/lib/RetailcrmLogger.php index 7d6ff20..8bbf666 100644 --- a/retailcrm/lib/RetailcrmLogger.php +++ b/retailcrm/lib/RetailcrmLogger.php @@ -210,9 +210,14 @@ class RetailcrmLogger public static function clearObsoleteLogs() { $logDir = self::getLogDir(); + + if (!is_dir($logDir)) { + return; + } + $handle = opendir($logDir); while (($file = readdir($handle)) !== false) { - if (false !== self::checkFileName($file)) { + if (self::checkFileName($file) !== false) { $path = "$logDir/$file"; if (filemtime($path) < strtotime('-30 days')) { unlink($path); @@ -226,9 +231,13 @@ class RetailcrmLogger $fileNames = []; $logDir = self::getLogDir(); + if (!is_dir($logDir)) { + return; + } + $handle = opendir($logDir); - while (false !== $file = readdir($handle)) { - if (false !== self::checkFileName($file)) { + while ($file = readdir($handle) !== false) { + if (self::checkFileName($file) !== false) { $path = "$logDir/$file"; $fileNames[] = [ 'name' => $file, diff --git a/retailcrm/lib/events/RetailcrmAbandonedCartsEvent.php b/retailcrm/lib/events/RetailcrmAbandonedCartsEvent.php index 066260b..0274129 100644 --- a/retailcrm/lib/events/RetailcrmAbandonedCartsEvent.php +++ b/retailcrm/lib/events/RetailcrmAbandonedCartsEvent.php @@ -63,7 +63,7 @@ class RetailcrmAbandonedCartsEvent extends RetailcrmAbstractEvent implements Ret $syncCartsActive = Configuration::get(RetailCRM::SYNC_CARTS_ACTIVE); if (empty($syncCartsActive)) { - RetailcrmLogger::writeCaller(__METHOD__, 'Abandoned carts is disabled, skipping...'); + RetailcrmLogger::writeDebug(__METHOD__, 'Abandoned carts is disabled, skipping...'); continue; }