From ecdc41663508f0a5ea242fe249aa5a9a3a741ba6 Mon Sep 17 00:00:00 2001 From: Ryan Cousart Date: Sun, 17 Apr 2016 16:56:15 -0400 Subject: [PATCH] Fixing bug with non-static parents for dropdowns The offset of the parent was only being subtracted if the dropdown was facing down, this now subtracts it if the dropdown is facing up as well. This more or less applies the same fix as https://github.com/select2/select2/commit/e260860789db87c68ed2889895c76a22e94dbce1, but when calculating the position of the dropdown when it is facing up. This closes https://github.com/select2/select2/issues/3303 This closes https://github.com/select2/select2/pull/4267 --- src/js/select2/dropdown/attachBody.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/select2/dropdown/attachBody.js b/src/js/select2/dropdown/attachBody.js index 0b6d96c2..70a10d40 100644 --- a/src/js/select2/dropdown/attachBody.js +++ b/src/js/select2/dropdown/attachBody.js @@ -182,7 +182,7 @@ define([ if (newDirection == 'above' || (isCurrentlyAbove && newDirection !== 'below')) { - css.top = container.top - dropdown.height; + css.top = container.top - parentOffset.top - dropdown.height; } if (newDirection != null) {