From 2d579db3b5dd5a493daaa537803ff204cb64778c Mon Sep 17 00:00:00 2001 From: Uryvskiy Dima Date: Tue, 5 Dec 2023 17:31:02 +0300 Subject: [PATCH] fix tests --- src/include/class-wc-retailcrm-uploader.php | 7 ++----- tests/test-wc-retailcrm-base.php | 2 +- tests/test-wc-retailcrm-uploader.php | 1 - 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/include/class-wc-retailcrm-uploader.php b/src/include/class-wc-retailcrm-uploader.php index 0a4d9df..2c9241a 100644 --- a/src/include/class-wc-retailcrm-uploader.php +++ b/src/include/class-wc-retailcrm-uploader.php @@ -176,10 +176,9 @@ if (class_exists('WC_Retailcrm_Uploader') === false) { $result = $wpdb->get_results("SELECT COUNT(ID) as `count` FROM $wpdb->posts WHERE post_type = 'shop_order'"); } - return $result[0]->count ?? 0; + return $result[0]->count ? (int) $result[0]->count : 0; } - /** * Return users ids * @@ -197,7 +196,6 @@ if (class_exists('WC_Retailcrm_Uploader') === false) { ); } - /** * Return count users * @@ -207,10 +205,9 @@ if (class_exists('WC_Retailcrm_Uploader') === false) { { $userCount = count_users(); - return empty($userCount['total_users']) === false ? $userCount['total_users'] : 0; + return $userCount['total_users'] ? (int) $userCount['total_users'] : 0; } - /** * Array keys must be orders ID's in WooCommerce, values must be strings (error messages). * diff --git a/tests/test-wc-retailcrm-base.php b/tests/test-wc-retailcrm-base.php index 1285fb9..aa280df 100644 --- a/tests/test-wc-retailcrm-base.php +++ b/tests/test-wc-retailcrm-base.php @@ -252,7 +252,7 @@ class WC_Retailcrm_Base_Test extends WC_Retailcrm_Test_Case_Helper $this->baseRetailcrm->count_upload_data(); $uploadInfo = $this->getJsonData(ob_get_contents()); - var_dump($uploadInfo); + $this->assertInternalType('array', $uploadInfo); $this->assertArrayHasKey('count_orders', $uploadInfo); $this->assertArrayHasKey('count_users', $uploadInfo); diff --git a/tests/test-wc-retailcrm-uploader.php b/tests/test-wc-retailcrm-uploader.php index 1fc35b0..eec6ff3 100644 --- a/tests/test-wc-retailcrm-uploader.php +++ b/tests/test-wc-retailcrm-uploader.php @@ -109,7 +109,6 @@ class WC_Retailcrm_Uploader_Test extends WC_Retailcrm_Test_Case_Helper { $retailcrm_uploader = $this->getRetailcrmUploader($this->apiMock); $count_orders = $retailcrm_uploader->getCountOrders(); - var_dump($count_orders); $this->assertInternalType('int', $count_orders); }