mirror/openseadragon
1
0
Fork 0
mirror of https://github.com/openseadragon/openseadragon.git synced 2025-04-03 22:03:31 +03:00
Code Issues Projects Releases Wiki Activity

Resolved Duplicate IDs in overlay HTML

Browse source 
Fixed Overlay ID Issue

Ensured that overlay elements always have a unique ID.

If the element has an ID, it's used (overlay-wrapper-[elementID]).

If no ID exists, a random unique ID is generated (crypto.randomUUID()).

Added a class (openseadragon-overlay-wrapper) to all overlays for easier selection.
This commit is contained in:
Lokaesshwar 2025-03-14 00:45:17 +05:30 • committed by GitHub
parent 595066abd1
commit 0af819ee16
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 3 deletions

10
src/overlay.js
View file

@ -133,14 +133,18 @@
this.elementWrapper.appendChild(this.element);
if (this.element.id) {
this.elementWrapper.id = "overlay-wrapper-" + this.element.id;
this.elementWrapper.id = "overlay-wrapper-" + this.element.id;
} else {
this.elementWrapper.id = "overlay-wrapper";
this.elementWrapper.id = "overlay-wrapper-" + crypto.randomUUID(); // Ensure unique ID
}
// Always add a class for easier selection
this.elementWrapper.classList.add("openseadragon-overlay-wrapper");
this.style = this.elementWrapper.style;
this._init(options);
};
};
/** @lends OpenSeadragon.Overlay.prototype */
$.Overlay.prototype = {