diff --git a/src/openseadragon.js b/src/openseadragon.js index c5f2ce5c..1fa8bb1c 100644 --- a/src/openseadragon.js +++ b/src/openseadragon.js @@ -2906,6 +2906,7 @@ function OpenSeadragon( options ){ /** * Promise proxy in OpenSeadragon, enables $.supportsAsync feature. + * This proxy is also necessary because OperaMini does not implement Promises (checks fail). * @type {PromiseConstructor} */ $.Promise = window["Promise"] && $.supportsAsync ? window["Promise"] : class { diff --git a/src/tilesource.js b/src/tilesource.js index a5442e0f..3073af0a 100644 --- a/src/tilesource.js +++ b/src/tilesource.js @@ -435,7 +435,7 @@ $.TileSource.prototype = { /** * Responsible for retrieving, and caching the * image metadata pertinent to this TileSources implementation. - * There are three scenarios of opening a tile source: + * There are three scenarios of opening a tile source: providing a parseable string, plain object, or an URL. * This method is only called by OSD if the TileSource configuration is a non-parseable string (~url). * * The string can contain a hash `#` symbol, followed by @@ -727,8 +727,6 @@ $.TileSource.prototype = { * particularly if you want to use empty TiledImage with client-side derived data * only. The default tile-cache key is then called "" - an empty string. * - * todo AIOSA: provide another hash function that maps data onto tiles 1:1 (e.g sobel) or 1:m (vignetting) - * * Note: default behaviour does not take into account post data. * @param {Number} level tile level it was fetched with * @param {Number} x x-coordinate in the pyramid level diff --git a/test/modules/ajax-tiles.js b/test/modules/ajax-tiles.js index 78b4446d..0b1b21f0 100644 --- a/test/modules/ajax-tiles.js +++ b/test/modules/ajax-tiles.js @@ -50,13 +50,6 @@ ajaxHeaders: { 'X-Viewer-Header': 'ViewerHeaderValue' }, - // TODO: this test proves that tile cacheKey does not change - // with headers change, which by default are part of the key, - // but we cannot automatically update them since users might - // manually change it long before... or can we? The tile gets - // reloaded, so user code should get re-executed. IMHO, - // with tile propagation the best would be throw away old tile - // and start anew callTileLoadedWithCachedData: true }); }, diff --git a/test/modules/tilecache.js b/test/modules/tilecache.js index d6c0a3da..3b2fddbb 100644 --- a/test/modules/tilecache.js +++ b/test/modules/tilecache.js @@ -350,9 +350,6 @@ const workingc00 = tile00.getCache(tile00._wcKey); test.notEqual(workingc00, workingc12, "Underlying working cache is not shared despite tiles share hash key."); - //TODO fix test from here - test.ok("TODO: FIX TEST SUITE FOR NEW CACHE SYSTEM"); - // now set value with keeping origin await tile00.setData(42, T_D); const newCache = tile00.getCache(tile00._wcKey);