RetailCRM-Mirror/doctrine2
1
0
Fork 0
mirror of synced 2025-04-03 13:23:37 +03:00
Code Issues Projects Releases Wiki Activity

#1206 DDC-3430 - PersistentCollection should not mutate the given Criteria instances when matching()

Browse source
This commit is contained in:
Marco Pivetta 2015-01-17 08:30:16 +01:00
parent f8072dd8e0
commit e9fd5678a5
1 changed files with 24 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
tests/Doctrine/Tests/ORM/Functional/PersistentCollectionTest.php
View file

@ -2,6 +2,7 @@
namespace Doctrine\Tests\ORM\Functional; namespace Doctrine\Tests\ORM\Functional;
use Doctrine\Common\Collections\Criteria;
use Doctrine\Common\Persistence\PersistentObject; use Doctrine\Common\Persistence\PersistentObject;
/** /**
@ -69,6 +70,29 @@ class PersistentCollectionTest extends \Doctrine\Tests\OrmFunctionalTestCase
$this->assertFalse($collection->isEmpty()); $this->assertFalse($collection->isEmpty());
$this->assertFalse($collection->isInitialized()); $this->assertFalse($collection->isInitialized());
} }
/**
* @group #1206
* @group DDC-3430
*/
public function testMatchingDoesNotModifyTheGivenCriteria()
{
$collectionHolder = new PersistentCollectionHolder();
$this->_em->persist($collectionHolder);
$this->_em->flush();
$this->_em->clear();
$criteria = new Criteria();
$collectionHolder = $this->_em->find(__NAMESPACE__ . '\PersistentCollectionHolder', $collectionHolder->getId());
$collectionHolder->getCollection()->matching($criteria);
$this->assertEmpty($criteria->getWhereExpression());
$this->assertEmpty($criteria->getFirstResult());
$this->assertEmpty($criteria->getMaxResults());
$this->assertEmpty($criteria->getOrderings());
}
} }
/** /**